LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: [RFC] breakage in 4223cc34365e4 (h8300: uaccess.h update)
Date: Sun, 2 Mar 2008 23:23:14 +0000	[thread overview]
Message-ID: <20080302232314.GW27894@ZenIV.linux.org.uk> (raw)

	After that commit in asm-h8300/uaccess.h we have 

#define get_user(x, ptr)                                        \
({                                                              \
    int __gu_err = 0;                                           \
    uint32_t __gu_val = 0;                              \
    ^^^^^^^^^^^^^^^^^
    switch (sizeof(*(ptr))) {                                   \
    case 1:                                                     \
    case 2:                                                     \
    case 4:                                                     \
        __gu_val = *(ptr);                                      \
        break;                                                  \
    case 8:                                                     \
        memcpy(&__gu_val, ptr, sizeof (*(ptr)));                \
                               ^^^^^^^^^^^^^^^^

which, of course, is FUBAR whenever we actually hit that case - memcpy of
8 bytes into uint32_t is obviously wrong.  Why don't we simply do

#define get_user(x, ptr)                                        \
({                                                              \
    int __gu_err = 0;                                           \
    typeof(*(ptr)) __gu_val = *ptr;                             \
    switch (sizeof(*(ptr))) {                                   \
    case 1:                                                     \
    case 2:                                                     \
    case 4:                                                     \
    case 8:                                                     \
        break;                                                  \
    default:                                                    \
        __gu_err = __get_user_bad();                            \
        break;                                                  \
    }                                                           \
    (x) = __gu_val;                                             \
    __gu_err;                                                   \
})

and be done with that, anyway?

             reply	other threads:[~2008-03-02 23:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-02 23:23 Al Viro [this message]
2008-03-10 20:57 ` Yoshinori Sato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080302232314.GW27894@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=ysato@users.sourceforge.jp \
    --subject='Re: [RFC] breakage in 4223cc34365e4 (h8300: uaccess.h update)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).