LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: torvalds@linux-foundation.org, hans.rosenfeld@amd.com,
	linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: bisected boot regression post 2.6.25-rc3.. please revert
Date: Mon, 3 Mar 2008 08:46:20 +0100	[thread overview]
Message-ID: <20080303074620.GC5934@elte.hu> (raw)
In-Reply-To: <20080301105646.2c8620d9@laptopd505.fenrus.org>


* Arjan van de Ven <arjan@linux.intel.com> wrote:

> Hi Linus, Ingo, Hans,
> 
> Please revert commit cded932b75ab0a5f9181ee3da34a0a488d1a14fd ( x86: 
> fix pmd_bad and pud_bad to support huge pages ) since it prevents the 
> kernel to finish booting on my (Penryn based) laptop. The boot stops 
> right after freeing the init memory. Took a while to bisect (due to it 
> touching page*.h, which forces a full recompile), but it definitely is 
> caused by this commit...

hm, lets figure out why this patch breaks your box, ok? We obviously 
have to revert it if we cannot figure it out, but lets at least try - 
because the patch itself fixes a real regression and it's not obviously 
wrong either. I think there might be some bug hiding somewhere that we 
really want to fix instead of this revert.

Could you try to hack up a debug patch perhaps? Uninline the fucntion(s) 
then add two versions (one is that breaks on your box and one is that 
works on your box) of this same pmd_bad()/pud_bad() functions and do 
something like this (pseudocode):

pmd_bad()
{
	if (pmd_bad_working(x) != pmd_bad_broken(x))
		panic_timeout++;

	return pmd_bad_working(x);
}

i.e. we actually use the working function so your box should boot up 
just fine - but we instrument things with the broken function as well 
and detect the cases where the two values differ. It is an anomaly if 
either function ever returns true instead of false.

if after bootup you have a non-zero panic_timeout then there is a 
material difference somewhere. In that case try to stick a dump_stack() 
into the above case as well - and if the box still boots, send us the 
stackdumps. (if the box doesnt boot then perhaps the printout itself 
hangs - in that case try a save_stack_trace() hack and print it out 
later)

	Ingo

  reply	other threads:[~2008-03-03  7:46 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-01 18:56 Arjan van de Ven
2008-03-03  7:46 ` Ingo Molnar [this message]
2008-03-03  9:13   ` Ingo Molnar
2008-03-03 16:41     ` Arjan van de Ven
2008-03-03 17:40       ` Ingo Molnar
2008-03-03 17:51         ` Nish Aravamudan
2008-03-03 17:55           ` Ingo Molnar
2008-03-03 17:58             ` H. Peter Anvin
2008-03-03 18:36         ` Arjan van de Ven
2008-03-03 18:44           ` Linus Torvalds
2008-03-03 22:00             ` Arjan van de Ven
2008-03-04  1:05               ` Arjan van de Ven
2008-03-04  6:53                 ` Ingo Molnar
2008-03-05 15:35                   ` Arjan van de Ven
2008-03-09 11:56             ` Ingo Molnar
2008-03-09 17:27               ` Linus Torvalds
2008-03-09 18:57                 ` Ingo Molnar
2008-03-10  2:45                 ` Jeremy Fitzhardinge
2008-03-10  4:35                 ` Paul Mackerras
2008-03-03 21:13           ` Segher Boessenkool
2008-03-03 21:22             ` Segher Boessenkool
2008-03-03 22:33               ` Segher Boessenkool
2008-03-03 22:55                 ` H. Peter Anvin
2008-03-03 22:56                 ` Jeremy Fitzhardinge
2008-03-03 23:04                   ` H. Peter Anvin
2008-03-04  6:58             ` Ingo Molnar
2008-03-03 17:15 ` Nish Aravamudan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080303074620.GC5934@elte.hu \
    --to=mingo@elte.hu \
    --cc=arjan@linux.intel.com \
    --cc=hans.rosenfeld@amd.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: bisected boot regression post 2.6.25-rc3.. please revert' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).