LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: hpa@zytor.com, tglx@linutronix.de, andi@firstfloor.org,
	hch@infradead.org, linux-kernel@vger.kernel.org,
	Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [patch 1/2] x86, fpu: split FPU state from task struct - v2
Date: Mon, 3 Mar 2008 09:50:00 +0100	[thread overview]
Message-ID: <20080303085000.GB15943@elte.hu> (raw)
In-Reply-To: <20080301005141.997705000@linux-os.sc.intel.com>


* Suresh Siddha <suresh.b.siddha@intel.com> wrote:

> Split the FPU save area from the task struct. This allows easy 
> migration of FPU context, and it's generally cleaner. It also allows 
> the following two optimizations:
> 
> 1) only allocate when the application actually uses FPU, so in the 
> first lazy FPU trap. This could save memory for non-fpu using apps. 
> Next patch does this lazy allocation.
> 
> 2) allocate the right size for the actual cpu rather than 512 bytes 
> always. Patches enabling xsave/xrstor support (coming shortly) will 
> take advantage of this.

thanks, i've applied your two patches to x86.git#testing.

the #ifdefs are still a bit ugly:

> +#ifndef arch_task_cache_init
> +#define arch_task_cache_init()
> +#endif

use a __weak alias instead. (that way if an architecture defines the 
function, that function takes over automatically at link time, without 
any #ifdef complications)

> +#ifndef arch_dup_task_struct
> +static inline int arch_dup_task_struct(struct task_struct *dst,
> +				       struct task_struct *src)
> +{
> +	*dst = *src;
> +	return 0;
> +}
> +#endif

ditto.

	Ingo

  parent reply	other threads:[~2008-03-03  8:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-01  0:51 Suresh Siddha
2008-03-01  0:51 ` [patch 2/2] x86, fpu: lazy allocation of FPU area " Suresh Siddha
2008-03-01 12:41   ` Andi Kleen
2008-03-03  8:50 ` Ingo Molnar [this message]
2008-03-03  9:14   ` [patch 1/2] x86, fpu: split FPU state from task struct " Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080303085000.GB15943@elte.hu \
    --to=mingo@elte.hu \
    --cc=andi@firstfloor.org \
    --cc=arjan@linux.intel.com \
    --cc=hch@infradead.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    --subject='Re: [patch 1/2] x86, fpu: split FPU state from task struct - v2' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).