LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: hpa@zytor.com, tglx@linutronix.de, andi@firstfloor.org,
hch@infradead.org, linux-kernel@vger.kernel.org,
Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [patch 1/2] x86, fpu: split FPU state from task struct - v2
Date: Mon, 3 Mar 2008 10:14:16 +0100 [thread overview]
Message-ID: <20080303091416.GA18078@elte.hu> (raw)
In-Reply-To: <20080303085000.GB15943@elte.hu>
* Ingo Molnar <mingo@elte.hu> wrote:
> > 2) allocate the right size for the actual cpu rather than 512 bytes
> > always. Patches enabling xsave/xrstor support (coming shortly) will
> > take advantage of this.
>
> thanks, i've applied your two patches to x86.git#testing.
hm, qa immediately got problems with it:
[ 20.054821] BUG: sleeping function called from invalid context at mm/slab.c:3055
[ 20.057253] in_atomic():0, irqs_disabled():1
[ 20.057253] no locks held by awk/1294.
[ 20.057253] irq event stamp: 5745
[ 20.057253] hardirqs last enabled at (5745): [<ffffffff8079aaf0>] trace_hardirqs_on_thunk+0x35/0x3a
[ 20.057253] hardirqs last disabled at (5744): [<ffffffff8079ab2a>] trace_hardirqs_off_thunk+0x35/0x37
[ 20.057253] softirqs last enabled at (0): [<ffffffff80237800>] copy_process+0x310/0x16b0
[ 20.057253] softirqs last disabled at (0): [<0000000000000000>] 0x0
[ 20.057253] Pid: 1294, comm: awk Not tainted 2.6.25-rc3 #2
[ 20.057253]
[ 20.057253] Call Trace:
[ 20.057253] [<ffffffff8025bfb0>] ? print_irqtrace_events+0x110/0x120
[ 20.057253] [<ffffffff80230de5>] __might_sleep+0xe5/0x110
[ 20.057253] [<ffffffff802a9c53>] kmem_cache_alloc+0xe3/0x100
[ 20.057253] [<ffffffff80213f84>] init_fpu+0x94/0xf0
[ 20.057253] [<ffffffff8020e6d8>] math_state_restore+0x58/0x70
[ 20.057253] [<ffffffff8079bb39>] error_exit+0x0/0xb8
[ 20.057253]
[ 35.722463] device: 'vcs1': device_add
that's a non-atomic alloc in an atomic (irqs off) section ...
Ingo
prev parent reply other threads:[~2008-03-03 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-01 0:51 Suresh Siddha
2008-03-01 0:51 ` [patch 2/2] x86, fpu: lazy allocation of FPU area " Suresh Siddha
2008-03-01 12:41 ` Andi Kleen
2008-03-03 8:50 ` [patch 1/2] x86, fpu: split FPU state from task struct " Ingo Molnar
2008-03-03 9:14 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080303091416.GA18078@elte.hu \
--to=mingo@elte.hu \
--cc=andi@firstfloor.org \
--cc=arjan@linux.intel.com \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--subject='Re: [patch 1/2] x86, fpu: split FPU state from task struct - v2' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).