LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] fix mount option parsing for ext3/4
@ 2008-03-03 21:10 Josef Bacik
  0 siblings, 0 replies; only message in thread
From: Josef Bacik @ 2008-03-03 21:10 UTC (permalink / raw)
  To: linux-ext4; +Cc: linux-kernel, akpm

Hello,

Noticed that the "resize" option won't be noticed as it comes after the NULL 
option, so if you try to mount (or in this case remount) with that option it 
won't be recognized.  Both ext3 and ext4 have this problem.  Thank you,

Signed-off-by: Josef Bacik <jbacik@redhat.com>

Index: linux-2.6/fs/ext3/super.c
===================================================================
--- linux-2.6.orig/fs/ext3/super.c
+++ linux-2.6/fs/ext3/super.c
@@ -806,8 +806,8 @@ static match_table_t tokens = {
 	{Opt_quota, "quota"},
 	{Opt_usrquota, "usrquota"},
 	{Opt_barrier, "barrier=%u"},
-	{Opt_err, NULL},
 	{Opt_resize, "resize"},
+	{Opt_err, NULL},
 };
 
 static ext3_fsblk_t get_sb_block(void **data)
Index: linux-2.6/fs/ext4/super.c
===================================================================
--- linux-2.6.orig/fs/ext4/super.c
+++ linux-2.6/fs/ext4/super.c
@@ -944,8 +944,8 @@ static match_table_t tokens = {
 	{Opt_mballoc, "mballoc"},
 	{Opt_nomballoc, "nomballoc"},
 	{Opt_stripe, "stripe=%u"},
-	{Opt_err, NULL},
 	{Opt_resize, "resize"},
+	{Opt_err, NULL},
 };
 
 static ext4_fsblk_t get_sb_block(void **data)

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-03-03 21:24 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-03 21:10 [PATCH] fix mount option parsing for ext3/4 Josef Bacik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).