LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: netdev@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org,
	Stephen Hemminger <shemminger@linux-foundation.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: locking api self-test hanging
Date: Tue, 4 Mar 2008 08:40:24 +0000	[thread overview]
Message-ID: <20080304084024.GA3980@ff.dom.local> (raw)
In-Reply-To: <20080303210540.cea55e13.akpm@linux-foundation.org>

On 04-03-2008 06:05, Andrew Morton wrote:
...
>>>> And I've fully bisected this hang twice and both times came up with
>>>>
>>>> commit 33f807ba0d9259e7c75c7a2ce8bd2787e5b540c7
>>>> Author: Stephen Hemminger <shemminger@linux-foundation.org>
>>>> Date:   Mon Nov 19 19:24:52 2007 -0800
>>>>
>>>>     [NETPOLL]: Kill NETPOLL_RX_DROP, set but never tested.
>>>>
>>>> which is stupid because that patch doesn't do anything.

...or maybe apparently doesn't do anything?

@@ -128,13 +127,11 @@ static int poll_one_napi(struct netpoll_info *npinfo,
        if (!test_bit(NAPI_STATE_SCHED, &napi->state))
                return budget;
 
-       npinfo->rx_flags |= NETPOLL_RX_DROP;


But in a next patch we can see:

@@ -51,12 +50,12 @@ static inline int netpoll_rx(struct sk_buff *skb)
        unsigned long flags;
        int ret = 0;
 
-       if (!npinfo || (!npinfo->rx_np && !npinfo->rx_flags))
+       if (!npinfo || !npinfo->rx_np)

So, it seems rx_flags could have been tested here for NETPOLL_RX_DROP
yet?

Regards,
Jarek P.

  parent reply	other threads:[~2008-03-04  8:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-03 23:02 Andrew Morton
2008-02-03 23:07 ` Andrew Morton
2008-02-04 12:43   ` Andrew Morton
2008-02-04 13:04     ` Andrew Morton
2008-02-04 13:14       ` Peter Zijlstra
2008-02-05 13:23       ` Bernhard Walle
2008-02-04 13:18     ` Andrew Morton
2008-02-06  8:34     ` Andrew Morton
2008-02-06  9:16       ` Andrew Morton
2008-03-04  5:05         ` Andrew Morton
2008-03-04  8:06           ` [patch] mark netconsole broken Ingo Molnar
2008-03-04 16:19             ` Randy Dunlap
2008-03-04 20:30             ` David Miller
2008-03-04 20:52               ` Ingo Molnar
2008-03-04  8:40           ` Jarek Poplawski [this message]
2008-03-04  9:10             ` locking api self-test hanging Andrew Morton
2008-03-04 19:04           ` Marcin Slusarz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080304084024.GA3980@ff.dom.local \
    --to=jarkao2@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=netdev@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=shemminger@linux-foundation.org \
    --subject='Re: locking api self-test hanging' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).