LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Dave Jones <davej@codemonkey.org.uk>,
	Andi Kleen <andi@firstfloor.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
	Pierre Ossman <drzeus-list@drzeus.cx>,
	LKML <linux-kernel@vger.kernel.org>,
	Adam Belay <abelay@novell.com>, Lee Revell <rlrevell@joe-job.com>,
	linux-pm@lists.linux-foundation.org
Subject: Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors
Date: Tue, 4 Mar 2008 10:40:28 +0100	[thread overview]
Message-ID: <20080304094028.GC15255@one.firstfloor.org> (raw)
In-Reply-To: <20080304040048.GA31562@codemonkey.org.uk>

On Mon, Mar 03, 2008 at 11:00:48PM -0500, Dave Jones wrote:
> On Tue, Mar 04, 2008 at 12:10:33AM +0100, Andi Kleen wrote:
>  > On Mon, Mar 03, 2008 at 06:05:35PM -0500, Alan Stern wrote:
>  > > On Mon, 3 Mar 2008, Pallipadi, Venkatesh wrote:
>  > > 
>  > > > But, with this patch:
>  > > > - we are penalizing good hardware and making them less power efficient
>  > > > to match the bad ones.
>  > > > - There may also be server systems which first may not have these sort
>  > > > of power fluctuations and even when buggy and have this noise, system
>  > > > may be in some corner of some lab with fans making more noise than the
>  > > > capacitors.
>  > > 
>  > > Can you make it configurable through sysfs?  
>  > 
>  > It already is, through a writable module_parm() 
>  > 
>  > > Default to disabled, but 
>  > > allow the user to turn it on if the machine makes too much noise.
>  > 
>  > 99+% of the users wouldn't be able to figure that out.
> 
> 99+% of users don't have singing capacitors. (Or don't care enough to complain)
> For those that do can't figure out what to do from google,
> we have a documentation problem.

The big question is if there is a measurable difference in power consumption
from a reasonable default value.  I doubt it actually. The normal rule
of thumb is that if you average sleeps are long enough (and they still
stay this way even with the patch enabled) you're doing ok. If there is 
no or not significant penalty there is no reason to not enable it by default.

-Andi

  parent reply	other threads:[~2008-03-04  9:39 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-29 18:38 [RFC][PATCH] " Pierre Ossman
2008-02-29 21:44 ` Lennart Sorensen
2008-03-01 12:31   ` Pierre Ossman
2008-03-01 13:40 ` Pierre Ossman
2008-03-02  2:27 ` Lee Revell
2008-03-02 14:17   ` Pierre Ossman
2008-03-03 12:36 ` Andi Kleen
2008-03-03 20:18 ` [PATCH] " Pierre Ossman
2008-03-03 20:46   ` Pavel Machek
2008-03-03 21:03     ` Pierre Ossman
2008-03-03 21:08       ` Pavel Machek
2008-03-03 21:14         ` Pallipadi, Venkatesh
2008-03-03 21:17           ` Pierre Ossman
2008-03-03 22:04             ` Pallipadi, Venkatesh
2008-03-03 23:05               ` [linux-pm] " Alan Stern
2008-03-03 23:10                 ` Andi Kleen
2008-03-04  4:00                   ` Dave Jones
2008-03-04  6:14                     ` Pierre Ossman
2008-03-04 17:19                       ` Pierre Ossman
2008-03-04 17:29                         ` Andi Kleen
2008-03-04 17:30                           ` Pierre Ossman
2008-03-04 17:43                             ` Andi Kleen
2008-03-04 18:04                               ` Pierre Ossman
2008-03-04 18:34                                 ` Andi Kleen
2008-03-05  6:04                                   ` Pierre Ossman
2008-03-05 15:48                                     ` Andi Kleen
2008-03-05 16:53                                       ` Pierre Ossman
2008-03-05 17:32                                         ` Andi Kleen
2008-03-04 19:01                         ` Pallipadi, Venkatesh
2008-03-05  6:02                           ` Pierre Ossman
2008-03-05  8:40                             ` Pierre Ossman
2008-03-05  9:03                               ` Pavel Machek
2008-03-05 13:42                                 ` Pierre Ossman
2008-03-05 13:47                                   ` Pavel Machek
2008-03-05 13:52                                     ` Pierre Ossman
2008-03-06  8:27                               ` Pierre Ossman
2008-03-09 14:16                                 ` Pierre Ossman
2008-03-09 18:19                                   ` Rafael J. Wysocki
2008-03-09 18:50                                   ` Alan Stern
2008-03-09 19:30                                   ` Henrique de Moraes Holschuh
2008-03-09 20:14                                     ` Pierre Ossman
2008-03-09 20:41                                       ` Henrique de Moraes Holschuh
2008-03-09 20:54                                         ` Henrique de Moraes Holschuh
2008-03-10 10:00                                   ` Pavel Machek
2008-03-10 12:49                                     ` Pierre Ossman
2008-03-10 13:04                                       ` Andi Kleen
2008-03-10 13:29                                         ` Pierre Ossman
2008-03-12 19:11                                       ` Len Brown
2008-03-13  8:10                                         ` Pavel Machek
2008-03-13 10:42                                           ` Andi Kleen
2008-03-14  4:13                                             ` Len Brown
2008-03-13 16:34                                         ` Pierre Ossman
2008-03-13 16:47                                           ` Pallipadi, Venkatesh
2008-03-13 17:44                                             ` Pierre Ossman
2008-03-13 17:49                                           ` Pierre Ossman
2008-03-14 19:40                                           ` Pierre Ossman
2008-03-14 21:15                                             ` Pallipadi, Venkatesh
2008-03-15  0:41                                               ` Pierre Ossman
2008-03-11  7:51                                   ` Pierre Ossman
2008-03-11 10:48                                     ` Andi Kleen
2008-03-11 15:20                                       ` Pierre Ossman
2008-03-11 17:31                                         ` Pierre Ossman
2008-03-12 19:17                                       ` Len Brown
2008-03-12 20:31                               ` Len Brown
2008-03-04  9:40                     ` Andi Kleen [this message]
2008-03-03 23:09               ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080304094028.GC15255@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=abelay@novell.com \
    --cc=davej@codemonkey.org.uk \
    --cc=drzeus-list@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=rlrevell@joe-job.com \
    --cc=stern@rowland.harvard.edu \
    --cc=venkatesh.pallipadi@intel.com \
    --subject='Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).