LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Greg KH <gregkh@suse.de>
Cc: "Zhang, Rui" <rui.zhang@intel.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	kay.sievers@vrfy.org, Andrew Morton <akpm@linux-foundation.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Alexey Dobriyan <adobriyan@sw.ru>
Subject: Re: 2.6.25-rc regression: kernel panic on boot
Date: Tue, 4 Mar 2008 14:54:47 +0100	[thread overview]
Message-ID: <20080304135447.GD32383@elte.hu> (raw)
In-Reply-To: <20080303224259.GA27008@suse.de>


* Greg KH <gregkh@suse.de> wrote:

> On Mon, Mar 03, 2008 at 07:25:49AM +0800, Zhang, Rui wrote:
> > Hi, all,
> > 
> > kernel panic on boot when I try to run 2.6.25-rc1 and later, but 2.6.24-rc8 boots okay.
> > The result of git-bisect shows that
> > edfaa7c36574f1bf09c65ad602412db9da5f96bf is first bad commit.
> > 
> > The git-bisect-result and the dmesg log when the kernel panic are 
> > attached. Any help on this please? :)
> 
> Are you using LVM?  If so, please either upgrade your userspace/initrd 
> stuff, or enable CONFIG_SYSFS_DEPCRECATED

we _really_ must handle this differently and this _is_ a regression that 
multiple people have spent hours on bisecting already ...

So "enable CONFIG_SYSFS_DEPCRECATED" is _NOT_ the right answer, and this 
has been pointed out to you in the past.

the problem is that SYSFS_DEPRECATED changed its meaning mid-course. Now 
it means a different set of udev breakages. The correct way is to 
_RENAME_ that darn option to SYSFS_DEPRECATED_V2 (via the patch below), 
and to discontinue the user-configurability of the old SYSFS_DEPRECATED 
option. Viola, things work just fine - and the fact of SYSFS_DEPRECATED 
changing its meaning is documented as well.

this way any tester who comes over the 'make oldconfig' route is not hit 
in the head with a nasty regression ...

tested patch below. (and this is one of those rare cases where 'select' 
is the right thing to do in a Kconfig entry)

	Ingo

---------------------->
Subject: sysfs: CONFIG_SYSFS_DEPRECATED fix
From: Ingo Molnar <mingo@elte.hu>
Date: Tue Mar 04 14:35:21 CET 2008

CONFIG_SYSFS_DEPRECATED=y changed its meaning recently and causes
regressions in working setups that had SYSFS_DEPRECATED disabled.

so rename it to SYSFS_DEPRECATED_V2 so that testers pick up the new
default via 'make oldconfig', even if their old .config's disabled
CONFIG_SYSFS_DEPRECATED ...

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 init/Kconfig |    4 ++++
 1 file changed, 4 insertions(+)

Index: linux/init/Kconfig
===================================================================
--- linux.orig/init/Kconfig
+++ linux/init/Kconfig
@@ -367,9 +367,13 @@ config RESOURCE_COUNTERS
 	depends on CGROUPS
 
 config SYSFS_DEPRECATED
+	bool
+
+config SYSFS_DEPRECATED_V2
 	bool "Create deprecated sysfs files"
 	depends on SYSFS
 	default y
+	select SYSFS_DEPRECATED
 	help
 	  This option creates deprecated symlinks such as the
 	  "device"-link, the <subsystem>:<name>-link, and the

  parent reply	other threads:[~2008-03-04 13:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-02 23:25 Zhang, Rui
2008-03-03 22:42 ` Greg KH
2008-03-03 18:33   ` Zhang, Rui
2008-03-04 13:54   ` Ingo Molnar [this message]
2008-03-04 18:43     ` Andrew Morton
2008-03-04 19:33       ` Greg KH
2008-03-04 20:04         ` Linus Torvalds
2008-03-04 20:24           ` Greg KH
2008-03-05 13:25             ` Ingo Molnar
2008-03-05  1:19       ` [dm-devel] " Alasdair G Kergon
2008-03-05 10:16     ` Alexey Dobriyan
2008-03-05 13:29       ` Ingo Molnar
2008-03-05 15:37       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080304135447.GD32383@elte.hu \
    --to=mingo@elte.hu \
    --cc=adobriyan@sw.ru \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@suse.de \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=rui.zhang@intel.com \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: 2.6.25-rc regression: kernel panic on boot' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).