LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] document de_thread() with exit_notify() connection
@ 2008-03-03  4:17 Oleg Nesterov
  2008-03-04  8:38 ` Roland McGrath
  0 siblings, 1 reply; 3+ messages in thread
From: Oleg Nesterov @ 2008-03-03  4:17 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Roland McGrath, linux-kernel

Add a couple of small comments, it is not easy to see what this code does.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>

--- 25/fs/exec.c~7_DOC_EXIT_EXEC	2008-02-17 23:40:07.000000000 +0300
+++ 25/fs/exec.c	2008-03-03 06:54:31.000000000 +0300
@@ -802,7 +802,7 @@ static int de_thread(struct task_struct 
 	if (!thread_group_leader(tsk)) {
 		leader = tsk->group_leader;
 
-		sig->notify_count = -1;
+		sig->notify_count = -1;	/* for exit_notify() */
 		for (;;) {
 			write_lock_irq(&tasklist_lock);
 			if (likely(leader->exit_state))
--- 25/kernel/exit.c~7_DOC_EXIT_EXEC	2008-03-03 06:46:00.000000000 +0300
+++ 25/kernel/exit.c	2008-03-03 07:07:17.000000000 +0300
@@ -808,6 +808,7 @@ static void exit_notify(struct task_stru
 		state = EXIT_DEAD;
 	tsk->exit_state = state;
 
+	/* mt-exec, de_thread() is waiting for us */
 	if (thread_group_leader(tsk) &&
 	    tsk->signal->notify_count < 0 &&
 	    tsk->signal->group_exit_task)


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-03-04 15:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-03  4:17 [PATCH] document de_thread() with exit_notify() connection Oleg Nesterov
2008-03-04  8:38 ` Roland McGrath
2008-03-04 15:54   ` Oleg Nesterov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).