LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Robin Getz <rgetz@blackfin.uclinux.org>
To: rusty@rustcorp.com.au, "Andrew Morton" <akpm@linux-foundation.org>
Cc: "LKML" <linux-kernel@vger.kernel.org>
Subject: PATCH [1/1]: Don't return symbol lables in init sections after they have been freed
Date: Tue, 4 Mar 2008 18:47:15 -0500 [thread overview]
Message-ID: <200803041847.15884.rgetz@blackfin.uclinux.org> (raw)
From: Robin Getz <rgetz@blackfin.uclinux.org>
Today, when module names are looked up, we do not qualify them (check to see
if the init section is still active or not). This can lead to problems when
kernel modules get loaded into the same address that the kernel init section
(or other module's init section was at). We sometimes return the old / no
lomnger there
This leads to bogus OOPS messages, and developers wasting their time looking
for problems (in the kernel init section) where there are none (since it was
a module).
This patch qualifies the addresses, to make sure the addresses are still valid
before label/offset.
Signed-off-by: Robin Getz <rgetz@blackfin.uclinux.org>
---
linux-2.6.x/kernel/kallsyms.c | 3 ++-
linux-2.6.x/kernel/module.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
Index: linux-2.6.x/kernel/kallsyms.c
===================================================================
--- linux-2.6.x/kernel/kallsyms.c (revision 4212)
+++ linux-2.6.x/kernel/kallsyms.c (working copy)
@@ -42,7 +42,8 @@
static inline int is_kernel_inittext(unsigned long addr)
{
- if (addr >= (unsigned long)_sinittext
+ if (system_state == SYSTEM_BOOTING
+ && addr >= (unsigned long)_sinittext
&& addr <= (unsigned long)_einittext)
return 1;
return 0;
Index: linux-2.6.x/kernel/module.c
===================================================================
--- linux-2.6.x/kernel/module.c (revision 4212)
+++ linux-2.6.x/kernel/module.c (working copy)
@@ -2121,7 +2121,8 @@
struct module *mod;
list_for_each_entry(mod, &modules, list) {
- if (within(addr, mod->module_init, mod->init_size)
+ if ((within(addr, mod->module_init, mod->init_size)
+ && mod->state == MODULE_STATE_COMING)
|| within(addr, mod->module_core, mod->core_size)) {
if (modname)
*modname = mod->name;
next reply other threads:[~2008-03-04 23:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 23:47 Robin Getz [this message]
2008-03-05 0:05 ` Andrew Morton
2008-03-06 5:13 ` Greg KH
2008-03-05 1:43 ` Rusty Russell
2008-03-05 17:53 ` Robin Getz
2008-04-02 22:01 ` Robin Getz
2008-04-03 23:41 ` Rusty Russell
2008-04-05 5:13 ` Robin Getz
2008-04-06 4:14 ` Robin Getz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803041847.15884.rgetz@blackfin.uclinux.org \
--to=rgetz@blackfin.uclinux.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--subject='Re: PATCH [1/1]: Don'\''t return symbol lables in init sections after they have been freed' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).