LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [2.6 patch] crypto/digest.c should #include "internal.h"
@ 2008-02-27 21:21 Adrian Bunk
  2008-03-05 11:06 ` Herbert Xu
  0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2008-02-27 21:21 UTC (permalink / raw)
  To: herbert, davem; +Cc: linux-crypto, linux-kernel

Every file should include the headers containing the externs for its 
global code (in this case for struct crypto_{init,exit}_digest_ops()).

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---
8680cc7b83fdcef7fbb84f9eac3f26f3d3e16b45 foobar
diff --git a/crypto/digest.c b/crypto/digest.c
index 6fd43bd..b526cc3 100644
--- a/crypto/digest.c
+++ b/crypto/digest.c
@@ -21,6 +21,8 @@
 #include <linux/module.h>
 #include <linux/scatterlist.h>
 
+#include "internal.h"
+
 static int init(struct hash_desc *desc)
 {
 	struct crypto_tfm *tfm = crypto_hash_tfm(desc->tfm);


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [2.6 patch] crypto/digest.c should #include "internal.h"
  2008-02-27 21:21 [2.6 patch] crypto/digest.c should #include "internal.h" Adrian Bunk
@ 2008-03-05 11:06 ` Herbert Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2008-03-05 11:06 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: davem, linux-crypto, linux-kernel

On Wed, Feb 27, 2008 at 11:21:03PM +0200, Adrian Bunk wrote:
> Every file should include the headers containing the externs for its 
> global code (in this case for struct crypto_{init,exit}_digest_ops()).
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>

Applied to crypto-2.6.  Thanks!
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-03-05 11:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-27 21:21 [2.6 patch] crypto/digest.c should #include "internal.h" Adrian Bunk
2008-03-05 11:06 ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).