LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Martin Schwidefsky <schwidefsky@de.ibm.com> To: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org Cc: Stefan Weinhuber <wein@de.ibm.com>, Martin Schwidefsky <schwidefsky@de.ibm.com> Subject: [patch 04/10] dasd: let dasd erp matching recognize alias recovery Date: Wed, 05 Mar 2008 12:54:36 +0100 [thread overview] Message-ID: <20080305115713.799161805@de.ibm.com> (raw) In-Reply-To: 20080305115432.691030908@de.ibm.com [-- Attachment #1: 004-dasd-erp.diff --] [-- Type: text/plain, Size: 1342 bytes --] From: Stefan Weinhuber <wein@de.ibm.com> When a request fails that was started on an alias device then the first recovery step is to retry it on the base device. If the recovery request fails again with the same symptoms, the next step should not be a simple retry, but should be a proper recovery based on sense data, etc. To do so, the dasd recovery functions need to recognize the alias recovery step in the erp chain by comparing the start devices. Signed-off-by: Stefan Weinhuber <wein@de.ibm.com> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com> --- drivers/s390/block/dasd_3990_erp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) Index: quilt-2.6/drivers/s390/block/dasd_3990_erp.c =================================================================== --- quilt-2.6.orig/drivers/s390/block/dasd_3990_erp.c +++ quilt-2.6/drivers/s390/block/dasd_3990_erp.c @@ -2310,10 +2310,8 @@ static int dasd_3990_erp_error_match(struct dasd_ccw_req *cqr1, struct dasd_ccw_req *cqr2) { - /* check failed CCW */ - if (cqr1->irb.scsw.cpa != cqr2->irb.scsw.cpa) { - // return 0; /* CCW doesn't match */ - } + if (cqr1->startdev != cqr2->startdev) + return 0; if (cqr1->irb.esw.esw0.erw.cons != cqr2->irb.esw.esw0.erw.cons) return 0; -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2008-03-05 12:02 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-03-05 11:54 [patch 00/10] s390 bux fixes for 2.6.25-rc4 Martin Schwidefsky 2008-03-05 11:54 ` [patch 01/10] Update default configuration Martin Schwidefsky 2008-03-05 11:54 ` [patch 02/10] idle: Fix machine check handling in idle loop Martin Schwidefsky 2008-03-05 11:54 ` [patch 03/10] Get rid of memcpy gcc warning workaround Martin Schwidefsky 2008-03-05 11:54 ` Martin Schwidefsky [this message] 2008-03-05 11:54 ` [patch 05/10] dasd: fix reference counting in display method for proc/dasd/devices Martin Schwidefsky 2008-03-05 11:54 ` [patch 06/10] sclp_vt220: speed up console output for interactive work Martin Schwidefsky 2008-03-05 11:54 ` [patch 07/10] zcrypt: fix ap_device_list handling Martin Schwidefsky 2008-03-05 11:54 ` [patch 08/10] Fix IPL from NSS Martin Schwidefsky 2008-03-05 11:54 ` [patch 09/10] Load disabled wait psw if reipl fails Martin Schwidefsky 2008-03-05 11:54 ` [patch 10/10] incorrect reipl nss name Martin Schwidefsky
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080305115713.799161805@de.ibm.com \ --to=schwidefsky@de.ibm.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=wein@de.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).