LKML Archive on
help / color / mirror / Atom feed
From: Rusty Russell <>
To: Robin Getz <>
Cc: "Andrew Morton" <>,
	"LKML" <>
Subject: Re: PATCH [1/1]: Don't return symbol lables in init sections after they have been freed
Date: Wed, 5 Mar 2008 12:43:26 +1100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wednesday 05 March 2008 10:47:15 Robin Getz wrote:
> From: Robin Getz <>
> Today, when module names are looked up, we do not qualify them (check to
> see if the init section is still active or not). This can lead to problems
> when kernel modules get loaded into the same address that the kernel init
> section (or other module's init section was at). We sometimes return the
> old / no lomnger there
> This leads to bogus OOPS messages, and developers wasting their time
> looking for problems (in the kernel init section) where there are none
> (since it was a module).

Hi Robin,

    This is a great explanation, with only one problem: it isn't true.  
mod->init_size is set to zero after init.

    Kernel submitters learn not to express doubts about their patches, lest 
they be dropped.  But it makes the job of maintainers even harder, since we 
don't know what's tested and what's an educated guess.

    As to the actual patch, your kallsyms.c patch matches 
a2da4052f1df6bc77749f84496fe731ab8b458f7's change to extable.c: please 
resubmit with just that one.  For bonus points, look at combining the extable 
and kallsyms logic so we don't diverge in future...


  parent reply	other threads:[~2008-03-05  1:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-04 23:47 Robin Getz
2008-03-05  0:05 ` Andrew Morton
2008-03-06  5:13   ` Greg KH
2008-03-05  1:43 ` Rusty Russell [this message]
2008-03-05 17:53   ` Robin Getz
2008-04-02 22:01   ` Robin Getz
2008-04-03 23:41     ` Rusty Russell
2008-04-05  5:13       ` Robin Getz
2008-04-06  4:14       ` Robin Getz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: PATCH [1/1]: Don'\''t return symbol lables in init sections after they have been freed' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).