From: "Ahmed S. Darwish" <darwish.07@gmail.com> To: Casey Schaufler <casey@schaufler-ca.com> Cc: Linus Torvalds <torvalds@linux-foundation.org>, Stephen Smalley <sds@tycho.nsa.gov>, James Morris <jmorris@namei.org>, Eric Paris <eparis@parisplace.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH BUGFIX -rc3] Smack: Don't register smackfs if we're not loaded Date: Wed, 5 Mar 2008 14:44:45 +0200 Message-ID: <20080305124445.GA19549@ubuntu> (raw) In-Reply-To: <521493.30745.qm@web36606.mail.mud.yahoo.com> On Tue, Mar 04, 2008 at 09:45:04AM -0800, Casey Schaufler wrote: > ----- Original Message ---- > > From: Linus Torvalds <torvalds@linux-foundation.org> > > To: Ahmed S. Darwish <darwish.07@gmail.com> > > Cc: Casey Schaufler <casey@schaufler-ca.com>; LKML <linux-kernel@vger.kernel.org> > > Sent: Tuesday, March 4, 2008 9:21:19 AM > > Subject: Re: [PATCH BUGFIX -rc3] Smack: Don't register smackfs if we're not loaded > > > > > > > > On Tue, 4 Mar 2008, Ahmed S. Darwish wrote: > > > > > > Smackfs initialization without an enabled Smack leads to > > > an early Oops that renders the system unusable. > > > > I really think this is bogus. Global enables like this are just wrong, and > > a sign that something else bad is going on. > > > > What is the oops? Why does it happen? ... > > One solution would be to tighten the smackfs code so that it > handles the uninitialized LSM case properly. > IMHO no smackfs code should ever execute if smack isn't loaded. This means catching it from the very fist step where it registers itself in init_smk_fs instead of doing several if(we're enabled) cases in the code path. The solution should be a _general_ solution, _not_ a SMACK one cause SELinux sufferes from exactly the same problem. a.k.a: LSMs need a scalable way to know if they're enabled that makes everyone happy ( especially Linus ;) ). Regads to all, -- "Better to light a candle, than curse the darkness" Ahmed S. Darwish Homepage: http://darwish.07.googlepages.com Blog: http://darwish-07.blogspot.com
next prev parent reply index Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-03-04 17:45 Casey Schaufler 2008-03-04 18:12 ` Linus Torvalds 2008-03-05 0:58 ` James Morris 2008-03-05 12:12 ` Ahmed S. Darwish 2008-03-05 12:44 ` Ahmed S. Darwish [this message] 2008-03-05 12:51 ` Ahmed S. Darwish -- strict thread matches above, loose matches on Subject: below -- 2008-03-04 16:42 Casey Schaufler 2008-03-04 13:10 Ahmed S. Darwish 2008-03-04 17:21 ` Linus Torvalds 2008-03-04 18:24 ` Ahmed S. Darwish
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080305124445.GA19549@ubuntu \ --to=darwish.07@gmail.com \ --cc=casey@schaufler-ca.com \ --cc=eparis@parisplace.org \ --cc=jmorris@namei.org \ --cc=linux-kernel@vger.kernel.org \ --cc=sds@tycho.nsa.gov \ --cc=torvalds@linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lkml.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lkml.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lkml.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lkml.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lkml.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lkml.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lkml.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lkml.kernel.org/lkml/7 lkml/git/7.git git clone --mirror https://lkml.kernel.org/lkml/8 lkml/git/8.git git clone --mirror https://lkml.kernel.org/lkml/9 lkml/git/9.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lkml.kernel.org/lkml \ linux-kernel@vger.kernel.org public-inbox-index lkml Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git