LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Alexey Dobriyan <adobriyan@sw.ru>
Cc: Greg KH <gregkh@suse.de>, "Zhang, Rui" <rui.zhang@intel.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	kay.sievers@vrfy.org, Andrew Morton <akpm@linux-foundation.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: 2.6.25-rc regression: kernel panic on boot
Date: Wed, 5 Mar 2008 14:29:53 +0100	[thread overview]
Message-ID: <20080305132952.GD11701@elte.hu> (raw)
In-Reply-To: <20080305101617.GD19059@localhost.sw.ru>


* Alexey Dobriyan <adobriyan@sw.ru> wrote:

> On Tue, Mar 04, 2008 at 02:54:47PM +0100, Ingo Molnar wrote:
> > CONFIG_SYSFS_DEPRECATED=y changed its meaning recently and causes
> > regressions in working setups that had SYSFS_DEPRECATED disabled.
> > 
> > so rename it to SYSFS_DEPRECATED_V2 so that testers pick up the new
> > default via 'make oldconfig', even if their old .config's disabled
> > CONFIG_SYSFS_DEPRECATED ...
> 
> It has all the same help text, so people who disabled it in the past 
> will disable again!

please send a patch that changes the help text. For this to happen 
people have to change the default consciously.

> > +config SYSFS_DEPRECATED_V2
> >  	bool "Create deprecated sysfs files"
> >  	depends on SYSFS
> >  	default y
> > +	select SYSFS_DEPRECATED
> >  	help
> >  	  This option creates deprecated symlinks such as the
> >  	  "device"-link, the <subsystem>:<name>-link, and the
> 
> Is anyone aware of a case when turning SYSFS_DEPRECATED back on also 
> breaks something? I mean, option can be simply removed and sysfs 
> people can finally stop breaking boxes.

i have no strong opinion either way, but i think distributions that ship 
new userspace can legitimately disable this option.

That way once all new distributions have updated userspace we can flip 
the default around and can mark it 'default n'. This at least gives us a 
theoretical path towards getting rid of unwanted legacies. (I suspect 
this was the plan all along, it's just that the clock got restarted now 
with the different legacy/breakage property.)

longer term we could also put in a WARN_ON_ONCE() which kerneloops.org 
would automatically track. That would give an objective metric about 
when to change the default. (and when to get rid of the legacy 
altogether)

	Ingo

  reply	other threads:[~2008-03-05 13:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-02 23:25 Zhang, Rui
2008-03-03 22:42 ` Greg KH
2008-03-03 18:33   ` Zhang, Rui
2008-03-04 13:54   ` Ingo Molnar
2008-03-04 18:43     ` Andrew Morton
2008-03-04 19:33       ` Greg KH
2008-03-04 20:04         ` Linus Torvalds
2008-03-04 20:24           ` Greg KH
2008-03-05 13:25             ` Ingo Molnar
2008-03-05  1:19       ` [dm-devel] " Alasdair G Kergon
2008-03-05 10:16     ` Alexey Dobriyan
2008-03-05 13:29       ` Ingo Molnar [this message]
2008-03-05 15:37       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080305132952.GD11701@elte.hu \
    --to=mingo@elte.hu \
    --cc=adobriyan@sw.ru \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@suse.de \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=rui.zhang@intel.com \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: 2.6.25-rc regression: kernel panic on boot' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).