LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: oakad@exemail.com.au
Cc: linux-kernel@vger.kernel.org, oakad@yahoo.com
Subject: Re: [PATCH 11/11] memstick: add support for JMicron jmb38x MemoryStick host controller
Date: Wed, 5 Mar 2008 15:17:02 -0800	[thread overview]
Message-ID: <20080305151702.0d19f722.akpm@linux-foundation.org> (raw)
In-Reply-To: <1204646548-27466-12-git-send-email-oakad@exemail.com.au>

On Wed,  5 Mar 2008 03:02:28 +1100
oakad@exemail.com.au wrote:

> +static void jmb38x_ms_reset(struct jmb38x_ms_host *host)
> +{
> +	unsigned int host_ctl = readl(host->addr + HOST_CONTROL);
> +
> +	writel(host_ctl | HOST_CONTROL_RESET_REQ | HOST_CONTROL_RESET,
> +	       host->addr + HOST_CONTROL);
> +
> +	while (HOST_CONTROL_RESET_REQ
> +	       & (host_ctl = readl(host->addr + HOST_CONTROL))) {

host_ctl is written to but is not used again.

> +		ndelay(100);
> +		dev_dbg(&host->chip->pdev->dev, "reset\n");
> +	}
> +
> +	writel(INT_STATUS_ALL, host->addr + INT_STATUS_ENABLE);
> +	writel(INT_STATUS_ALL, host->addr + INT_SIGNAL_ENABLE);
> +
> +	dev_dbg(&host->chip->pdev->dev, "reset\n");
> +}

  reply	other threads:[~2008-03-05 23:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-04 16:02 MemoryStick driver updates oakad
2008-03-04 16:02 ` [PATCH 01/11] memstick: introduce correct definitions in the header oakad
2008-03-04 16:02   ` [PATCH 02/11] memstick: add memstick_suspend/resume_host methods oakad
2008-03-04 16:02     ` [PATCH 03/11] memstick: make sure number of command retries is exactly as specified oakad
2008-03-04 16:02       ` [PATCH 04/11] memstick: drop DRIVER_VERSION numbers as meaningless oakad
2008-03-04 16:02         ` [PATCH 05/11] tifm: fix the MemoryStick host fifo handling code oakad
2008-03-04 16:02           ` [PATCH 06/11] tifm: fix memorystick host initialization code oakad
2008-03-04 16:02             ` [PATCH 07/11] tifm: clear interrupt mask bits before setting them on adapter init oakad
2008-03-04 16:02               ` [PATCH 08/11] memstick: add support for decoding "specfile" media attributes oakad
2008-03-04 16:02                 ` [PATCH 09/11] memstick: fix parsing of "assembly_date" attribute field oakad
2008-03-04 16:02                   ` [PATCH 10/11] memstick: try harder to recover from unsuccessful interface mode switch oakad
2008-03-04 16:02                     ` [PATCH 11/11] memstick: add support for JMicron jmb38x MemoryStick host controller oakad
2008-03-05 23:17                       ` Andrew Morton [this message]
2008-03-05 22:59           ` [PATCH 05/11] tifm: fix the MemoryStick host fifo handling code Andrew Morton
2008-03-05 23:21 ` MemoryStick driver updates Andrew Morton
2008-03-06  2:29 [PATCH 11/11] memstick: add support for JMicron jmb38x MemoryStick host controller Alex Dubov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080305151702.0d19f722.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oakad@exemail.com.au \
    --cc=oakad@yahoo.com \
    --subject='Re: [PATCH 11/11] memstick: add support for JMicron jmb38x MemoryStick host controller' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).