LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] sched: make task_nice available to non-GPL modules
@ 2008-03-05 21:56 Pavel Roskin
2008-03-06 10:41 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Roskin @ 2008-03-05 21:56 UTC (permalink / raw)
To: Ingo Molnar, linux-kernel
The API is trivial, and so is the implementation. Linux priorities are
exposed to the userspace, so nobody should claim that software aware of
Linux priorities is a derived work of the kernel.
The complementary function set_user_nice() is available to non-GPL
modules. If the module can set the priority, it should be able to read
it back.
Signed-off-by: Pavel Roskin <proski@gnu.org>
---
kernel/sched.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index dcd553c..6db6e0c 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -4422,7 +4422,7 @@ int task_nice(const struct task_struct *p)
{
return TASK_NICE(p);
}
-EXPORT_SYMBOL_GPL(task_nice);
+EXPORT_SYMBOL(task_nice);
/**
* idle_cpu - is a given cpu idle currently?
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sched: make task_nice available to non-GPL modules
2008-03-05 21:56 [PATCH] sched: make task_nice available to non-GPL modules Pavel Roskin
@ 2008-03-06 10:41 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-03-06 10:41 UTC (permalink / raw)
To: Pavel Roskin; +Cc: linux-kernel
* Pavel Roskin <proski@gnu.org> wrote:
> The API is trivial, and so is the implementation. Linux priorities
> are exposed to the userspace, so nobody should claim that software
> aware of Linux priorities is a derived work of the kernel.
>
> The complementary function set_user_nice() is available to non-GPL
> modules. If the module can set the priority, it should be able to
> read it back.
i've applied this, but i removed the (incorrect) legal interpretation in
the commit message. We simply make it available generally, and the
export is not restricted to clearly internal modules only. (but that
does not mean that a module using it is not a derived work)
this is a fine but important distinction. If a module uses a GPL symbol,
it is a strong hint of being derived work. But by not using GPL-only
symbols (but using other symbols - or not using kernel symbols at all)
it might still be derived work and even if it's not derived work, it
might still fall under the GPL.
in other words: EXPORT_SYMBOL does not mean and never meant
EXPORT_SYMBOL_NON_GPL.
EXPORT_SYMBOL_GPL is EXPORT_SYMBOL_I_ADMIT_MY_MODULE_IS_DERIVED, and
EXPORT_SYMBOL is EXPORT_SYMBOL_ASK_YOUR_LAWYER.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-06 10:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-05 21:56 [PATCH] sched: make task_nice available to non-GPL modules Pavel Roskin
2008-03-06 10:41 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).