LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Greg KH <greg@kroah.com>, Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@elte.hu>
Subject: Re: [patch 1/5] vmalloc: do not check for freed locks on user maps
Date: Thu, 6 Mar 2008 03:28:19 +1100	[thread overview]
Message-ID: <200803060328.20349.nickpiggin@yahoo.com.au> (raw)
In-Reply-To: <20080305155117.447021903@linutronix.de>

On Thursday 06 March 2008 03:03, Thomas Gleixner wrote: 
> User maps do not contain kernel internal objects. No need to check
> them.

Why not? Depends on your definition of kernel internal... and
objects ;)

Drivers could create and manage some objects in this vmalloc
area. They are no longer internal if you map them to userspace,
but I still don't think you want to vunmap it until those
object lifetimes are finished.


> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Acked-by: Ingo Molnar <mingo@elte.hu>
> ---
>  mm/vmalloc.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: linux-2.6/mm/vmalloc.c
> ===================================================================
> --- linux-2.6.orig/mm/vmalloc.c
> +++ linux-2.6/mm/vmalloc.c
> @@ -382,7 +382,8 @@ static void __vunmap(const void *addr, i
>  		return;
>  	}
>
> -	debug_check_no_locks_freed(addr, area->size);
> +	if (!(area->flags & VM_USERMAP))
> +		debug_check_no_locks_freed(addr, area->size);
>
>  	if (deallocate_pages) {
>  		int i;


  reply	other threads:[~2008-03-05 16:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-05 16:03 [patch 0/5] object debugging infrastructure V2 Thomas Gleixner
2008-03-05 16:03 ` [patch 1/5] vmalloc: do not check for freed locks on user maps Thomas Gleixner
2008-03-05 16:28   ` Nick Piggin [this message]
2008-03-05 17:20     ` Thomas Gleixner
2008-03-05 22:56       ` Nick Piggin
2008-03-05 23:31         ` Thomas Gleixner
2008-03-06  2:34           ` Nick Piggin
2008-03-05 16:03 ` [patch 2/5] slab: add a flag to prevent debug_free checks on a kmem_cache Thomas Gleixner
2008-03-05 16:03 ` [patch 3/5] infrastructure to debug (dynamic) objects Thomas Gleixner
2008-03-05 16:04 ` [patch 4/5] debugobjects: add documentation Thomas Gleixner
2008-03-10 20:13   ` Randy Dunlap
2008-03-21 14:25     ` Thomas Gleixner
2008-03-05 16:04 ` [patch 5/5] debugobjects: add timer specific object debugging code Thomas Gleixner
2008-03-05 20:14   ` Thomas Gleixner
2008-03-05 18:53 ` [patch 0/5] object debugging infrastructure V2 Greg KH
2008-03-06  1:48 ` Greg KH
2008-03-06  7:54   ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803060328.20349.nickpiggin@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=akpm@linux-foundation.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --subject='Re: [patch 1/5] vmalloc: do not check for freed locks on user maps' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).