LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Jan Beulich <jbeulich@novell.com>,
	tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: fix typo(?) in step.c
Date: Wed,  5 Mar 2008 23:52:23 -0800 (PST)	[thread overview]
Message-ID: <20080306075223.BA28B2700FD@magilla.localdomain> (raw)
In-Reply-To: Ingo Molnar's message of  Wednesday, 5 March 2008 14:41:50 +0100 <20080305134150.GA16477@elte.hu>

> Roland - i guess this means block-stepping (a new ptrace feature in .25) 
> is not particularly well-tested. Do you have any standalone testcases 
> that could be run?

I'm pretty sure that noone really uses it yet.  The test I used when I
originally wrote the feature is in the ptrace-tests suite.  (See
http://sourceware.org/systemtap/wiki/utrace/tests about that suite.)
I haven't particularly tested it since then, if it got broken later.

http://sources.redhat.com/cgi-bin/cvsweb.cgi/tests/ptrace-tests/tests/block-step.c?cvsroot=systemtap

Be sure to compile with current kernel-headers, or hand-tweak to define
PTRACE_SINGLEBLOCK.  Use -std=gnu99 -D_GNU_SOURCE.

The bogon came in commit eee3af4a2c83a97fff107ddc445d9df6fded9ce4,
the introduction of the ptrace BTS stuff.  Sorry I did not scour and 
cite every problem in that patch, since I had NAK'd the entire thing
as needing more careful review and incremental introduction after 2.6.25.

As I said then, one of my concerns was with the low-level tweaks not yet
sufficiently baked, independent from my reservations about the ptrace
feature.  Your #if'ing out of the user ABI additions for 2.6.25 does
nothing to remove the unknown new risks from all the tweaks with fingers in
the low-level arch stuff.  This is the sort of thing I was concerned about.
(And this one is easy.)

The block-step test only tested that PTRACE_SINGLEBLOCK worked right.
I just souped it up to also test that PTRACE_SINGLESTEP still works
immediately afterwards.  This still does not show any problem from this
bug.  The case that would be broken by it is rather more arcane.  I
haven't worked out the test case that fails with the bogon.


Thanks,
Roland

  reply	other threads:[~2008-03-06  7:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-05  8:36 Jan Beulich
2008-03-05 13:41 ` Ingo Molnar
2008-03-06  7:52   ` Roland McGrath [this message]
2008-03-06 11:28     ` Ingo Molnar
2008-03-06 12:03       ` Roland McGrath
2008-03-06 13:11         ` Ingo Molnar
2008-03-10 11:53           ` Jan Beulich
2008-03-11  3:44             ` Roland McGrath
2008-03-06 11:34     ` Ingo Molnar
2008-03-06 12:16       ` Roland McGrath
2008-03-06 13:13         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080306075223.BA28B2700FD@magilla.localdomain \
    --to=roland@redhat.com \
    --cc=hpa@zytor.com \
    --cc=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH] x86: fix typo(?) in step.c' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).