LKML Archive on
help / color / mirror / Atom feed
From: Roland McGrath <>
To: Ingo Molnar <>
Cc: Jan Beulich <>,,,
Subject: Re: [PATCH] x86: fix typo(?) in step.c
Date: Thu,  6 Mar 2008 04:03:09 -0800 (PST)	[thread overview]
Message-ID: <20080306120309.E4BE52700FD@magilla.localdomain> (raw)
In-Reply-To: Ingo Molnar's message of  Thursday, 6 March 2008 12:28:19 +0100 <>

> * Roland McGrath <> wrote:
> > The bogon came in commit eee3af4a2c83a97fff107ddc445d9df6fded9ce4, the 
> > introduction of the ptrace BTS stuff.  Sorry I did not scour and cite 
> > every problem in that patch, since I had NAK'd the entire thing as 
> > needing more careful review and incremental introduction after 2.6.25.
> note that in -rc4 all those BTS ptrace extensions are disabled, see:

I know.  That completely misses the point I just made:

   As I said then, one of my concerns was with the low-level tweaks not yet
   sufficiently baked, independent from my reservations about the ptrace
   feature.  Your #if'ing out of the user ABI additions for 2.6.25 does
   nothing to remove the unknown new risks from all the tweaks with fingers in
   the low-level arch stuff.  This is the sort of thing I was concerned about.

You didn't revert the parts that ever could have caused problems for anyone
except those using the new ptrace extensions, i.e. changes to step.c,
context switch, whatever else was touched we've lost track of now.  I keep
saying that those are not baked, 100% independent of the ptrace feature.  
You don't seem to be hearing me.


  reply	other threads:[~2008-03-06 12:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-05  8:36 Jan Beulich
2008-03-05 13:41 ` Ingo Molnar
2008-03-06  7:52   ` Roland McGrath
2008-03-06 11:28     ` Ingo Molnar
2008-03-06 12:03       ` Roland McGrath [this message]
2008-03-06 13:11         ` Ingo Molnar
2008-03-10 11:53           ` Jan Beulich
2008-03-11  3:44             ` Roland McGrath
2008-03-06 11:34     ` Ingo Molnar
2008-03-06 12:16       ` Roland McGrath
2008-03-06 13:13         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080306120309.E4BE52700FD@magilla.localdomain \ \ \ \ \ \ \
    --subject='Re: [PATCH] x86: fix typo(?) in step.c' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).