LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Paul Jackson <pj@sgi.com>
Cc: David Rientjes <rientjes@google.com>,
	clameter@sgi.com, Lee.Schermerhorn@hp.com, ak@suse.de,
	linux-kernel@vger.kernel.org
Subject: Re: [patch -mm 4/4] mempolicy: remove includes for duplicate headers
Date: Fri, 7 Mar 2008 00:45:54 -0800	[thread overview]
Message-ID: <20080307004554.3ac5d173.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080306150148.2aa87468.pj@sgi.com>

On Thu, 6 Mar 2008 15:01:48 -0600 Paul Jackson <pj@sgi.com> wrote:

> David wrote:
> > It simply decreases the remote chance later that ...
> > 
> > The only way this would make things more fragile is if ...
> 
> Does anyone lurking on this thread know if there is an
> established convention in kernel code, whether to directly
> include all headers that your code explicitly needs, or
> whether it's ok to rely on indirect includes for such?
> 
> David and I could debate the fine points of which way is
> best until the cows come home; the two of us are good at
> that.  This is too minor an issue for that sort of effort.
> 

Directly including what you need is more robust than a) relying upon nested
inclusions by includees or b) relying upon preceding inclusions by
includers.

So we usually go that way, when we notice it and when we think about it.


  reply	other threads:[~2008-03-07  8:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-06 20:05 [patch -mm 1/4] mempolicy: move rebind functions David Rientjes
2008-03-06 20:05 ` [patch -mm 2/4] mempolicy: create mempolicy_operations structure David Rientjes
2008-03-06 20:05   ` [patch -mm 3/4] mempolicy: small header file cleanup David Rientjes
2008-03-06 20:05     ` [patch -mm 4/4] mempolicy: remove includes for duplicate headers David Rientjes
2008-03-06 20:19       ` Paul Jackson
2008-03-06 20:51         ` David Rientjes
2008-03-06 21:01           ` Paul Jackson
2008-03-07  8:45             ` Andrew Morton [this message]
2008-03-07 20:44   ` Regression: Re: [patch -mm 2/4] mempolicy: create mempolicy_operations structure Lee Schermerhorn
2008-03-07 21:48     ` David Rientjes
2008-03-07 21:57       ` Paul Jackson
2008-03-08 18:49       ` Lee Schermerhorn
2008-03-08 22:09         ` David Rientjes
2008-03-10 14:58           ` Lee Schermerhorn
2008-03-12 19:33       ` [PATCH] Mempolicy: fix parsing of tmpfs mpol mount option Lee Schermerhorn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080307004554.3ac5d173.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=Lee.Schermerhorn@hp.com \
    --cc=ak@suse.de \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pj@sgi.com \
    --cc=rientjes@google.com \
    --subject='Re: [patch -mm 4/4] mempolicy: remove includes for duplicate headers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).