LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Frank Sorenson <frank@tuxrocks.com>
Cc: kay.sievers@vrfy.org, Matt_Domsch@dell.com,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: [patch] revert "dcdbas: add DMI-based module autloading"
Date: Sat, 8 Mar 2008 09:22:43 +0100	[thread overview]
Message-ID: <20080308082243.GA18123@elte.hu> (raw)
In-Reply-To: <47D23B7E.3020505@tuxrocks.com>


* Frank Sorenson <frank@tuxrocks.com> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Frank Sorenson wrote:
> > I did some additional debugging, and I believe you're correct about it
> > being specific to my system.  The system seems to run fine until some
> > time during the boot.  I booted with "init=/bin/sh" (that's how the
> > system stayed up for 9 minutes), then it died when I tried starting
> > things up.  I've further narrowed the OOM down to udev (though it's not
> > entirely udev's fault, since 2.6.24 runs fine).
> > 
> > I ran your debug info tool before killing the box by running
> > /sbin/start_udev.  The output of the tool is at
> > http://tuxrocks.com/tmp/cfs-debug-info-2008.03.06-14.11.24
> > 
> > Something is apparently happening between 2.6.24 and 2.6.25-rc[34] which
> > causes udev (or something it calls) to behave very badly.
> 
> Found it.  The culprit is 8f47f0b688bba7642dac4e979896e4692177670b
>     dcdbas: add DMI-based module autloading
> 
>     DMI autoload dcdbas on all Dell systems.
> 
>     This looks for BIOS Vendor or System Vendor == Dell, so this should
>     work for systems both Dell-branded and those Dell builds but brands
>     for others.  It causes udev to load the dcdbas module at startup,
>     which is used by tools called by HAL for wireless control and
>     backlight control, among other uses.
> 
> What actually happens is that when udev loads the dcdbas module at 
> startup, modprobe apparently calls "modprobe dcdbas" itself, repeating 
> until the system runs out of resources (in this case, it OOMs).

nice work! I've attached the revert below against latest -git - just in 
case no-one can think of an obvious fix to this bug.

	Ingo

--------------------->
Subject: revert "dcdbas: add DMI-based module autloading"
From: Ingo Molnar <mingo@elte.hu>
Date: Sat Mar 08 09:09:16 CET 2008

Frank Sorenson reported that 2.6.25-rc OOMs on his box and
tracked it down to commit 8f47f0b688bba7642dac4e979896e4692177670b,
"dcdbas: add DMI-based module autloading". Frank says:

> What actually happens is that when udev loads the dcdbas module at
> startup, modprobe apparently calls "modprobe dcdbas" itself, repeating
> until the system runs out of resources (in this case, it OOMs).

revert the commit.

Bisected-by: Frank Sorenson <frank@tuxrocks.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 drivers/firmware/dcdbas.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Index: linux/drivers/firmware/dcdbas.c
===================================================================
--- linux.orig/drivers/firmware/dcdbas.c
+++ linux/drivers/firmware/dcdbas.c
@@ -658,5 +658,4 @@ MODULE_DESCRIPTION(DRIVER_DESCRIPTION " 
 MODULE_VERSION(DRIVER_VERSION);
 MODULE_AUTHOR("Dell Inc.");
 MODULE_LICENSE("GPL");
-/* Any System or BIOS claiming to be by Dell */
-MODULE_ALIAS("dmi:*:[bs]vnD[Ee][Ll][Ll]*:*");
+

  reply	other threads:[~2008-03-08  8:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-06 17:26 2.6.25-rc4 OOMs itself dead on bootup Frank Sorenson
2008-03-06 18:49 ` Ingo Molnar
2008-03-07 19:27   ` Frank Sorenson
2008-03-08  7:08     ` Frank Sorenson
2008-03-08  8:22       ` Ingo Molnar [this message]
2008-03-08 18:16         ` [patch] revert "dcdbas: add DMI-based module autloading" Kay Sievers
2008-03-08 18:57           ` Frank Sorenson
2008-03-08 13:53       ` 2.6.25-rc4 OOMs itself dead on bootup (modprobe bug?) Matt Domsch
2008-03-08 14:03         ` Frank Sorenson
2008-03-08 21:53           ` Jon Masters
2008-03-08 22:54             ` Kay Sievers
2008-03-09  3:41               ` Jon Masters

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080308082243.GA18123@elte.hu \
    --to=mingo@elte.hu \
    --cc=Matt_Domsch@dell.com \
    --cc=akpm@linux-foundation.org \
    --cc=frank@tuxrocks.com \
    --cc=gregkh@suse.de \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rjw@sisk.pl \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [patch] revert "dcdbas: add DMI-based module autloading"' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).