LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Liam Girdwood <lg@opensource.wolfsonmicro.com>
Cc: linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [UPDATED v3][PATCH 4/7] regulator: framework core
Date: Sat, 8 Mar 2008 10:30:08 -0800	[thread overview]
Message-ID: <20080308103008.5ecbdc7e.akpm@linux-foundation.org> (raw)
In-Reply-To: <1204997086.13653.48.camel@localhost.localdomain>

On Sat, 08 Mar 2008 17:24:46 +0000 Liam Girdwood <lg@opensource.wolfsonmicro.com> wrote:

> > Should be indented with a tab, not spacespacespacespace
> 
> This patch releases the lock in get_device_regulator(), makes
> get_lowest_stable_voltage() non inline and fixes a minor indentation
> issue.

OK, I'll toss it in there, thanks.

It sounds like significant changes will be happening and that we can expect
to see a new patchset?

I assume you noted my s/get_current/read_current/g fix?  It'll be needed for
alpha, frv and mn10300.  read_current() is a pretty crappy name but I couldn't
think of anything better.  It would look nicer if we also did
s/get_voltage/read_voltage/g - your call.

  reply	other threads:[~2008-03-08 18:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-06 18:11 Liam Girdwood
2008-03-07  8:39 ` Andrew Morton
2008-03-08 17:24   ` Liam Girdwood
2008-03-08 18:30     ` Andrew Morton [this message]
2008-03-09 11:18       ` Liam Girdwood
2008-03-07 16:10 ` Greg KH
2008-03-07 22:19   ` Liam Girdwood
2008-03-08  7:41     ` Greg KH
2008-03-08 21:18       ` Liam Girdwood
2008-03-09  3:16         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080308103008.5ecbdc7e.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lg@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [UPDATED v3][PATCH 4/7] regulator: framework core' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).