LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: rtc-linux@googlegroups.com, lkml <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@elte.hu>, Pavel Machek <pavel@ucw.cz>
Subject: Re: [patch 2.6.24-git] rtc: avoid legacy drivers with generic framework
Date: Sat, 8 Mar 2008 11:19:29 -0800	[thread overview]
Message-ID: <200803081119.31053.david-b@pacbell.net> (raw)
In-Reply-To: <200802101208.20593.david-b@pacbell.net>

On Sunday 10 February 2008, David Brownell wrote:
> Kconfig tweaks to help reduce RTC configuration bugs, by avoiding
> legacy RTC drivers when the generic RTC framework is enabled:
> 
>  - If rtc-cmos is selected, disable the legacy rtc driver;
> 
>  - When using generic RTC on x86, enable rtc-cmos by default;
> 
>  - In the old "chardev RTC" section of Kconfig, add a comment
>    warning people off these (seven) legacy RTC drivers when
>    the generic framework is in use.
> 
> People can still use the legacy drivers if they want (or need) to.
> 
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> 	...

Here's an update to that patch, which is in MMOTM with the name

	rtc-avoid-legacy-drivers-with-generic-framework.patch

=======
This is a harsher fix for the problems of trying to make legacy
RTCs coexist with the generic RTC framework:  Just Don't Do It.

The legacy drivers are not geared towards coexistence; they
never had a reason to try.  So rather than accumulating more
and more special cases, and gently nudging users away from the
old code, make it be an either/or choice.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
---
 drivers/char/Kconfig |   12 ++++++++----
 drivers/rtc/Kconfig  |    4 ----
 2 files changed, 8 insertions(+), 8 deletions(-)

--- g26.orig/drivers/char/Kconfig	2008-03-07 13:28:53.000000000 -0800
+++ g26/drivers/char/Kconfig	2008-03-07 13:35:07.000000000 -0800
@@ -704,14 +704,16 @@ config NVRAM
 	  To compile this driver as a module, choose M here: the
 	  module will be called nvram.
 
-comment "Avoid any legacy RTC drivers you may see here"
-	depends on RTC_LIB
+#
+# These legacy RTC drivers just cause too many conflicts with the generic
+# RTC framework ... let's not even try to coexist any more.
+#
+if RTC_LIB=n
 
 config RTC
 	tristate "Enhanced Real Time Clock Support"
 	depends on !PPC && !PARISC && !IA64 && !M68K && !SPARC && !FRV \
-			&& !ARM && !SUPERH && !S390 \
-			&& RTC_DRV_CMOS=n
+			&& !ARM && !SUPERH && !S390
 	---help---
 	  If you say Y here and create a character special file /dev/rtc with
 	  major number 10 and minor number 135 using mknod ("man mknod"), you
@@ -817,6 +819,8 @@ config DS1302
 	  will get access to the real time clock (or hardware clock) built
 	  into your computer.
 
+endif # RTC_LIB
+
 config COBALT_LCD
 	bool "Support for Cobalt LCD"
 	depends on MIPS_COBALT
--- g26.orig/drivers/rtc/Kconfig	2008-03-07 13:28:53.000000000 -0800
+++ g26/drivers/rtc/Kconfig	2008-03-07 13:31:28.000000000 -0800
@@ -20,10 +20,6 @@ menuconfig RTC_CLASS
 
 if RTC_CLASS
 
-if GEN_RTC || RTC
-comment "Conflicting RTC option has been selected, check GEN_RTC and RTC"
-endif
-
 config RTC_HCTOSYS
 	bool "Set system time from RTC on startup and resume"
 	depends on RTC_CLASS = y

      parent reply	other threads:[~2008-03-08 19:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-10 20:08 David Brownell
2008-02-11  9:54 ` [rtc-linux] " Alessandro Zummo
2008-03-08 19:19 ` David Brownell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803081119.31053.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pavel@ucw.cz \
    --cc=rtc-linux@googlegroups.com \
    --subject='Re: [patch 2.6.24-git] rtc: avoid legacy drivers with generic framework' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).