LKML Archive on
help / color / mirror / Atom feed
From: Roland McGrath <>
To: Oleg Nesterov <>
Cc: Andrew Morton <>,
	Arjan van de Ven <>,
	Ingo Molnar <>,
Subject: Re: [RFC, PATCH] signals: print_fatal_signal: fix the signr "calculation"
Date: Sat,  8 Mar 2008 11:03:11 -0800 (PST)	[thread overview]
Message-ID: <20080308190311.779B326F990@magilla.localdomain> (raw)
In-Reply-To: Oleg Nesterov's message of  Saturday, 8 March 2008 20:24:53 +0300 <>

The intent of your change is to get the printk for each thread, right?
I don't really see the point.  The thread that actually had the fault will
dequeue a non-SIGKILL signal and report its status.  We only need one
thread per signal to the print-out.

Hmm.  I see that non-coredump signals that hit the optimized fatal case in
__group_complete_signal will cause every thread to have a pending SIGKILL.
So that will be seen first and prevent the print-out.  So that's what you
intend to change?

I'm not sure print-fatal-signals was really ever intended for non-coredump
signals.  It doesn't seem like it would be all that useful.  It's probably
even undesireable for every normal C-c killing something to cause a printk.


  reply	other threads:[~2008-03-08 19:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-08 17:24 Oleg Nesterov
2008-03-08 19:03 ` Roland McGrath [this message]
2008-03-08 20:30   ` Oleg Nesterov
2008-03-09 11:05   ` Ingo Molnar
2008-03-09 16:11     ` Oleg Nesterov
2008-03-11  2:19       ` Roland McGrath
2008-03-11 18:22         ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080308190311.779B326F990@magilla.localdomain \ \ \ \ \ \ \
    --subject='Re: [RFC, PATCH] signals: print_fatal_signal: fix the signr "calculation"' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).