LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andres Salomon <dilinger@queued.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: adaplas@gmail.com, linux-kernel@vger.kernel.org,
	linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/4] gxfb: Replace FBSIZE config option with a kernel argument
Date: Sat, 8 Mar 2008 20:19:43 -0500	[thread overview]
Message-ID: <20080308201943.31cd89b3@ephemeral> (raw)
In-Reply-To: <20080227195839.1e86074e@ephemeral>

On Wed, 27 Feb 2008 19:58:39 -0500
Andres Salomon <dilinger@queued.net> wrote:

> On Wed, 27 Feb 2008 16:31:05 -0800
> Andrew Morton <akpm@linux-foundation.org> wrote:
> 
> > On Sat, 23 Feb 2008 01:10:45 -0500
> > Andres Salomon <dilinger@queued.net> wrote:
> > 
> > > @@ -425,7 +424,10 @@ static int __init gxfb_setup(char *options)
> > >  		if (!*opt)
> > >  			continue;
> > >  
> > > -		mode_option = opt;
> > > +		if (!strncmp(opt, "fbsize:", 7))
> > > +			fbsize = simple_strtoul(opt+7, NULL, 0);
> > > +		else
> > > +			mode_option = opt;
> > >  	}
> > 
> > The above shouldn't be necessary.
> 
> It looks like that's done in other drivers in case MODULE isn't defined.  I'm
> assuming this is historical at this point, and manual options parsing can
> be removed from all fb drivers at this point, or is there another reason
> why manual parsing would be necessary?
> 


Could I get an answer from the fbdevel folks about this?  It looks like
the fb_get_options stuff is there for backwards compatibility.
gxfb.fbsize=16777216 (for example) works regardless of whether or not
CONFIG_MODULES is set.  

It would appear that the only reason for fb_get_options() calling would
be to support video=gxfb:<options>.  Is this used any more?  Should it
be marked deprecated, and dropped from the geode fb drivers?


> 
> > 
> > And it should have been documented in Documentation/kernel-parameters.txt.
> 
> Yeah, I wasn't actually sure about that; I did check for other fb drivers
> documenting stuff in kernel-parameters.txt, and didn't see it.  It looks
> like they instead document stuff in Documentation/fb/.  Which is preferred?
> 


I'd also like an opinion about this.


> 
> 
> > 
> > And "fbsize=N" would be a lot more conventional than "fbsize:N"
> > 
> 
> I can certainly change that.  Regarding convention, I toyed with renaming
> it 'vram' (as most of the fb drivers use that), and will probably do
> that unless Jordan objects.
> 
> 
> > I suspect that the formulation you have here will not permit "fbsize:128k",
> > whereas "fbsize=128k" or "gxfb.fbsize=128k" should work.  Needs checking.
> > 
> > >  	return 0;
> > > @@ -456,5 +458,8 @@ module_exit(gxfb_cleanup);
> > >  module_param(mode_option, charp, 0);
> > >  MODULE_PARM_DESC(mode_option, "video mode (<x>x<y>[-<bpp>][@<refr>])");
> > >  
> > > +module_param(fbsize, int, 0);
> > > +MODULE_PARM_DESC(fbsize, "video memory size");
> > > +
> > 
> > Because the module_param() already makes fbsize available on the kernel
> > boot command line via gxfb.fbsize=42 (or something similar).
> > 
> > 

  parent reply	other threads:[~2008-03-09  1:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-23  6:10 Andres Salomon
2008-02-28  0:31 ` Andrew Morton
2008-02-28  0:58   ` Andres Salomon
2008-02-28  1:12     ` Jordan Crouse
2008-03-09  1:19     ` Andres Salomon [this message]
2008-03-09  1:19     ` [PATCH 1/4] " Andres Salomon
2008-03-09 18:12       ` Randy Dunlap
2008-03-09 22:00       ` [Linux-fbdev-devel] " Ondrej Zajicek
2008-03-09 23:57         ` Andres Salomon
2008-03-10  8:16           ` Geert Uytterhoeven
2008-03-11 20:25   ` Andres Salomon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080308201943.31cd89b3@ephemeral \
    --to=dilinger@queued.net \
    --cc=adaplas@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 1/4] gxfb: Replace FBSIZE config option with a kernel argument' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).