LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@tv-sign.ru>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>, Pavel Emelyanov <xemul@openvz.org>,
	Roland McGrath <roland@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 9/6] signals: fold sig_ignored() into prepare_signal()
Date: Mon, 10 Mar 2008 00:28:26 +0300	[thread overview]
Message-ID: <20080309212826.GA2013@tv-sign.ru> (raw)

(the last one on this)

Now that prepare_signal() returns int it can absorb the sig_ignored() check
to avoid the code duplication.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>

--- 25/kernel/signal.c~9_PS_CK_IGNORED	2008-03-09 23:07:26.000000000 +0300
+++ 25/kernel/signal.c	2008-03-10 00:11:50.000000000 +0300
@@ -645,7 +645,7 @@ static int prepare_signal(int sig, struc
 		}
 	}
 
-	return 1;
+	return !sig_ignored(p, sig);
 }
 
 /*
@@ -763,7 +763,7 @@ static int send_signal(int sig, struct s
 	 * exactly one non-rt signal, so that we can get more
 	 * detailed information about the cause of the signal.
 	 */
-	if (sig_ignored(t, sig) || legacy_queue(pending, sig))
+	if (legacy_queue(pending, sig))
 		return 0;
 
 	/*
@@ -1253,9 +1253,6 @@ int send_sigqueue(struct sigqueue *q, st
 	if (!likely(prepare_signal(sig, t)))
 		goto out;
 
-	if (sig_ignored(t, sig))
-		goto out;
-
 	ret = 0;
 	if (unlikely(!list_empty(&q->list))) {
 		/*


                 reply	other threads:[~2008-03-09 21:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080309212826.GA2013@tv-sign.ru \
    --to=oleg@tv-sign.ru \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=roland@redhat.com \
    --cc=xemul@openvz.org \
    --subject='Re: [PATCH 9/6] signals: fold sig_ignored() into prepare_signal()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).