LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] signals: cleanup the usage of print_fatal_signal()
@ 2008-03-10 21:17 Oleg Nesterov
  2008-03-11  2:20 ` Roland McGrath
  0 siblings, 1 reply; 2+ messages in thread
From: Oleg Nesterov @ 2008-03-10 21:17 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Ingo Molnar, Roland McGrath, linux-kernel

Move the callsite of print_fatal_signal() down, under
"if (sig_kernel_coredump(signr))", so we don't need to check signr != SIGKILL.

We are only interested in the sig_kernel_coredump() signals anyway, and due to
the previous changes we almost never can see other fatal signals here except
SIGKILL.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>

--- 25/kernel/signal.c~PFS_CLEANUP	2008-03-10 00:47:21.000000000 +0300
+++ 25/kernel/signal.c	2008-03-10 23:55:07.000000000 +0300
@@ -1766,9 +1766,10 @@ relock:
 		 * Anything else is fatal, maybe with a core dump.
 		 */
 		current->flags |= PF_SIGNALED;
-		if ((signr != SIGKILL) && print_fatal_signals)
-			print_fatal_signal(regs, signr);
+
 		if (sig_kernel_coredump(signr)) {
+			if (print_fatal_signals)
+				print_fatal_signal(regs, signr);
 			/*
 			 * If it was able to dump core, this kills all
 			 * other threads in the group and synchronizes with


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] signals: cleanup the usage of print_fatal_signal()
  2008-03-10 21:17 [PATCH] signals: cleanup the usage of print_fatal_signal() Oleg Nesterov
@ 2008-03-11  2:20 ` Roland McGrath
  0 siblings, 0 replies; 2+ messages in thread
From: Roland McGrath @ 2008-03-11  2:20 UTC (permalink / raw)
  To: Oleg Nesterov; +Cc: Andrew Morton, Ingo Molnar, linux-kernel

Looks right to me.  I'd prefer to see a comment before the added lines
and a blank line after them, though.


Thanks,
Roland

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-03-11  2:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-10 21:17 [PATCH] signals: cleanup the usage of print_fatal_signal() Oleg Nesterov
2008-03-11  2:20 ` Roland McGrath

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).