LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Avi Kivity <avi@qumranet.com>, Sam Ravnborg <sam@ravnborg.org>,
	kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>,
	David Howells <dhowells@redhat.com>,
	linux-arch@vger.kernel.org, mm-commits@vger.kernel.org
Subject: Re: [PATCH] kvm: provide kvm.h for all architecture: fixes headers_install
Date: Mon, 10 Mar 2008 23:20:39 -0700	[thread overview]
Message-ID: <20080310232039.d2a34f5a.akpm@linux-foundation.org> (raw)
In-Reply-To: <200803101411.04175.borntraeger@de.ibm.com>

On Mon, 10 Mar 2008 14:11:04 +0100 Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> [PATCH v2] kvm: provide kvm.h for all architecture: fixes headers_install
> 
> Currently include/linux/kvm.h is not considered by make headers_install, 
> because Kbuild cannot handle " unifdef-$(CONFIG_FOO) += foo.h. 
> This problem was introduced by 040922c04cf2c8ac70be2e88a8a9614ecdb41d2e, 
> which makes this an 2.6.25 regression.
> 
> One way of solving the issue is to enhance Kbuild, but Avi Kivity and David
> Woodhouse conviced me, that changing headers_install is not the way to go. 
> This patch changes the definition for linux/kvm.h to unifdef-y.
> 
> If  unifdef-y is used for linux/kvm.h "make headers_check" will fail on all
> architectures without asm/kvm.h. Therefore, this patch also provides 
> asm/kvm.h on all architectures.
> 
> Changes since v1:
> o use asm-generic/Kbuild.asm (Arnd Bergmann)
> o fix comment in asm-frv (David Howells)

err, this doesn't work.

alpha and m68k (at least) fail make headers_check

/usr/src/devel/usr/include/linux/kvm.h requires asm/kvm.h, which does not exist in exported headers

  reply	other threads:[~2008-03-11  6:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-07 12:26 headersinstall of kvm.h does not work Christian Borntraeger
2008-03-07 12:57 ` Avi Kivity
2008-03-07 13:57   ` Christian Borntraeger
2008-03-07 16:08     ` Avi Kivity
2008-03-07 23:43 ` David Woodhouse
2008-03-10  8:13   ` [PATCH] kvm: provide kvm.h for all architecture: fixes headers_install Christian Borntraeger
2008-03-10 11:23     ` Arnd Bergmann
2008-03-10 13:11   ` Christian Borntraeger
2008-03-11  6:20     ` Andrew Morton [this message]
2008-03-11  6:42       ` David Woodhouse
2008-03-11  7:10         ` Christian Borntraeger
2008-03-11  9:33           ` Andreas Schwab
2008-03-11 10:02             ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080310232039.d2a34f5a.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=avi@qumranet.com \
    --cc=borntraeger@de.ibm.com \
    --cc=dhowells@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mm-commits@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --subject='Re: [PATCH] kvm: provide kvm.h for all architecture: fixes headers_install' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).