LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [patch] fix ACPI boot regression (was: Re: Linux 2.6.25-rc5)
Date: Tue, 11 Mar 2008 02:04:31 -0400	[thread overview]
Message-ID: <200803110204.31709.lenb@kernel.org> (raw)
In-Reply-To: <20080310172417.GA25898@elte.hu>

On Monday 10 March 2008, Ingo Molnar wrote:
> 
> * Linus Torvalds <torvalds@linux-foundation.org> wrote:
> 
> > On Mon, 10 Mar 2008, Ingo Molnar wrote:
> > >
> > > so zero-extending the result in the PCI-BIOS read routine fixes the 
> > > regression on my laptop. ( It might fix some other long-standing 
> > > issues we had with PCI-BIOS during the past decade ... ) Both 8-bit 
> > > and 16-bit accesses were buggy.
> > 
> > Oh, wow. That must have been there forever, but very few people 
> > probably ever cared.
> > 
> > And why is your laptop using the BIOS routines anyway? Or was that 
> > just a result of your randconfig having turned off the sane config 
> > access routines?
> 
> yeah, randconfig generated this:
> 
>   CONFIG_PCI=y
>   CONFIG_PCI_GOBIOS=y
>   # CONFIG_PCI_GOMMCONFIG is not set
>   # CONFIG_PCI_GODIRECT is not set
>   # CONFIG_PCI_GOANY is not set
>   CONFIG_PCI_BIOS=y
> 
> which forced the PCI code into the BIOS access method on this otherwise 
> modern system. I disable some of the really-known-to-be-broken .config 
> options in randconfig - but i still bravely keept CONFIG_GO_PCIBIOS in 
> the randomized space, which triggered this.
> 
> On another box, which has a different BIOS, this bug never happened, in 
> tens of thousands of bootup tests.

I think this re-enforces three Axioms

1. Ingo rules!
2. Even the most obvious fix carries some risk
3. The more config options we maintain, the more fragmented is our test coverage.

thanks Ingo,
-Len


      reply	other threads:[~2008-03-11  6:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-10  5:42 Linux 2.6.25-rc5 Linus Torvalds
2008-03-10  6:05 ` charles gagalac
2008-03-10 14:45   ` Linus Torvalds
2008-03-10 17:04 ` [patch] fix ACPI boot regression (was: Re: Linux 2.6.25-rc5) Ingo Molnar
2008-03-10 17:14   ` Linus Torvalds
2008-03-10 17:24     ` Ingo Molnar
2008-03-11  6:04       ` Len Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803110204.31709.lenb@kernel.org \
    --to=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rjw@sisk.pl \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [patch] fix ACPI boot regression (was: Re: Linux 2.6.25-rc5)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).