LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Arjan van de Ven <arjan@infradead.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC, PATCH] signals: print_fatal_signal: fix the signr "calculation"
Date: Mon, 10 Mar 2008 19:19:28 -0700 (PDT)	[thread overview]
Message-ID: <20080311021928.B725E26F991@magilla.localdomain> (raw)
In-Reply-To: Oleg Nesterov's message of  Sunday, 9 March 2008 19:11:53 +0300 <20080309161153.GA76@tv-sign.ru>

> For various reasons we can't currently do the same for sig_kernel_coredump()
> signals. But, when rlim[RLIMIT_CORE] == 0, we don't actually need coredumping?
> So, we could do something like
> 
> 
> 	-	if (!sig_kernel_coredump(sig)) {
> 	+	if (!sig_kernel_coredump(sig) || !signal->rlim[RLIMIT_CORE]) {

I don't like this.  I think it's better to leave logic like RLIMIT_CORE
checks to the core dump code itself.


Thanks,
Roland

  reply	other threads:[~2008-03-11  2:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-08 17:24 Oleg Nesterov
2008-03-08 19:03 ` Roland McGrath
2008-03-08 20:30   ` Oleg Nesterov
2008-03-09 11:05   ` Ingo Molnar
2008-03-09 16:11     ` Oleg Nesterov
2008-03-11  2:19       ` Roland McGrath [this message]
2008-03-11 18:22         ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080311021928.B725E26F991@magilla.localdomain \
    --to=roland@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@tv-sign.ru \
    --subject='Re: [RFC, PATCH] signals: print_fatal_signal: fix the signr "calculation"' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).