LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: David Woodhouse <dwmw2@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Avi Kivity <avi@qumranet.com>, Sam Ravnborg <sam@ravnborg.org>,
	kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>,
	David Howells <dhowells@redhat.com>,
	linux-arch@vger.kernel.org, mm-commits@vger.kernel.org
Subject: Re: [PATCH] kvm: provide kvm.h for all architecture: fixes headers_install
Date: Tue, 11 Mar 2008 08:10:49 +0100	[thread overview]
Message-ID: <200803110810.49759.borntraeger@de.ibm.com> (raw)
In-Reply-To: <1205217745.2592.86.camel@shinybook.infradead.org>

Am Dienstag, 11. März 2008 schrieb David Woodhouse:
> 
> On Mon, 2008-03-10 at 23:20 -0700, Andrew Morton wrote:
> > 
> > > Changes since v1:
> > > o use asm-generic/Kbuild.asm (Arnd Bergmann)
> 
> I don't see that in the diffstat of the patch you dropped (looking at
> the immediately subsequent mail in my inbox). Which might explain...


I cross tested my patch on all architectures and, yes, that part did not make
it into mm. Maybe it was caused by my last patch being word wrapped.
Here is a resend:


[PATCH v2] kvm: provide kvm.h for all architecture: fixes headers_install

Currently include/linux/kvm.h is not considered by make headers_install, 
because Kbuild cannot handle " unifdef-$(CONFIG_FOO) += foo.h. 
This problem was introduced by 040922c04cf2c8ac70be2e88a8a9614ecdb41d2e, 
which makes this an 2.6.25 regression.

One way of solving the issue is to enhance Kbuild, but Avi and David 
conviced me, that changing headers_install is not the way to go. This patch 
changes the definition for linux/kvm.h to unifdef-y.

If  unifdef-y is used for linux/kvm.h "make headers_check" will fail on all
architectures without asm/kvm.h. Therefore, this patch also provides 
asm/kvm.h on all architectures.

Changes since v1:
o use asm-generic/Kbuild.asm (Arnd Bergmann)
o fix comment in asm-frv (David Howells)

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Acked-by: Avi Kivity <avi@qumranet.com>
CCed: Sam Ravnborg <sam@ravnborg.org
CCed: David Woodhouse <dwmw2@infradead.org>

---
 include/asm-alpha/kvm.h        |    6 ++++++
 include/asm-arm/kvm.h          |    6 ++++++
 include/asm-avr32/kvm.h        |    6 ++++++
 include/asm-blackfin/kvm.h     |    6 ++++++
 include/asm-cris/kvm.h         |    6 ++++++
 include/asm-frv/kvm.h          |    6 ++++++
 include/asm-generic/Kbuild.asm |    2 ++
 include/asm-h8300/kvm.h        |    6 ++++++
 include/asm-ia64/kvm.h         |    6 ++++++
 include/asm-m32r/kvm.h         |    6 ++++++
 include/asm-m68k/kvm.h         |    6 ++++++
 include/asm-m68knommu/kvm.h    |    6 ++++++
 include/asm-mips/kvm.h         |    6 ++++++
 include/asm-mn10300/kvm.h      |    6 ++++++
 include/asm-parisc/kvm.h       |    6 ++++++
 include/asm-powerpc/kvm.h      |    6 ++++++
 include/asm-s390/kvm.h         |    6 ++++++
 include/asm-sh/kvm.h           |    6 ++++++
 include/asm-sparc/kvm.h        |    6 ++++++
 include/asm-sparc64/kvm.h      |    6 ++++++
 include/asm-um/kvm.h           |    6 ++++++
 include/asm-v850/kvm.h         |    6 ++++++
 include/asm-xtensa/kvm.h       |    6 ++++++
 include/linux/Kbuild           |    2 +-
 24 files changed, 135 insertions(+), 1 deletion(-)

Index: linux-2.6.git/include/asm-alpha/kvm.h
===================================================================
--- /dev/null
+++ linux-2.6.git/include/asm-alpha/kvm.h
@@ -0,0 +1,6 @@
+#ifndef __LINUX_KVM_ALPHA_H
+#define __LINUX_KVM_ALPHA_H
+
+/* alpha does not support KVM */
+
+#endif
Index: linux-2.6.git/include/asm-arm/kvm.h
===================================================================
--- /dev/null
+++ linux-2.6.git/include/asm-arm/kvm.h
@@ -0,0 +1,6 @@
+#ifndef __LINUX_KVM_ARM_H
+#define __LINUX_KVM_ARM_H
+
+/* arm does not support KVM */
+
+#endif
Index: linux-2.6.git/include/asm-avr32/kvm.h
===================================================================
--- /dev/null
+++ linux-2.6.git/include/asm-avr32/kvm.h
@@ -0,0 +1,6 @@
+#ifndef __LINUX_KVM_AVR32_H
+#define __LINUX_KVM_AVR32_H
+
+/* avr32 does not support KVM */
+
+#endif
Index: linux-2.6.git/include/asm-blackfin/kvm.h
===================================================================
--- /dev/null
+++ linux-2.6.git/include/asm-blackfin/kvm.h
@@ -0,0 +1,6 @@
+#ifndef __LINUX_KVM_BLACKFIN_H
+#define __LINUX_KVM_BLACKFIN_H
+
+/* blackfin does not support KVM */
+
+#endif
Index: linux-2.6.git/include/asm-cris/kvm.h
===================================================================
--- /dev/null
+++ linux-2.6.git/include/asm-cris/kvm.h
@@ -0,0 +1,6 @@
+#ifndef __LINUX_KVM_CRIS_H
+#define __LINUX_KVM_CRIS_H
+
+/* cris does not support KVM */
+
+#endif
Index: linux-2.6.git/include/asm-frv/kvm.h
===================================================================
--- /dev/null
+++ linux-2.6.git/include/asm-frv/kvm.h
@@ -0,0 +1,6 @@
+#ifndef __LINUX_KVM_FRV_H
+#define __LINUX_KVM_FRV_H
+
+/* frv does not support KVM */
+
+#endif
Index: linux-2.6.git/include/asm-generic/Kbuild.asm
===================================================================
--- linux-2.6.git.orig/include/asm-generic/Kbuild.asm
+++ linux-2.6.git/include/asm-generic/Kbuild.asm
@@ -1,3 +1,5 @@
+header-y  += kvm.h
+
 ifeq ($(wildcard include/asm-$(SRCARCH)/a.out.h),include/asm-$(SRCARCH)/a.out.h)
 unifdef-y += a.out.h
 endif
Index: linux-2.6.git/include/asm-h8300/kvm.h
===================================================================
--- /dev/null
+++ linux-2.6.git/include/asm-h8300/kvm.h
@@ -0,0 +1,6 @@
+#ifndef __LINUX_KVM_H8300_H
+#define __LINUX_KVM_H8300_H
+
+/* h8300 does not support KVM */
+
+#endif
Index: linux-2.6.git/include/asm-ia64/kvm.h
===================================================================
--- /dev/null
+++ linux-2.6.git/include/asm-ia64/kvm.h
@@ -0,0 +1,6 @@
+#ifndef __LINUX_KVM_IA64_H
+#define __LINUX_KVM_IA64_H
+
+/* ia64 does not support KVM */
+
+#endif
Index: linux-2.6.git/include/asm-m32r/kvm.h
===================================================================
--- /dev/null
+++ linux-2.6.git/include/asm-m32r/kvm.h
@@ -0,0 +1,6 @@
+#ifndef __LINUX_KVM_M32R_H
+#define __LINUX_KVM_M32R_H
+
+/* m32r does not support KVM */
+
+#endif
Index: linux-2.6.git/include/asm-m68k/kvm.h
===================================================================
--- /dev/null
+++ linux-2.6.git/include/asm-m68k/kvm.h
@@ -0,0 +1,6 @@
+#ifndef __LINUX_KVM_M68K_H
+#define __LINUX_KVM_M68K_H
+
+/* m68k does not support KVM */
+
+#endif
Index: linux-2.6.git/include/asm-m68knommu/kvm.h
===================================================================
--- /dev/null
+++ linux-2.6.git/include/asm-m68knommu/kvm.h
@@ -0,0 +1,6 @@
+#ifndef __LINUX_KVM_M68KNOMMU_H
+#define __LINUX_KVM_M68KNOMMU_H
+
+/* m68knommu does not support KVM */
+
+#endif
Index: linux-2.6.git/include/asm-mips/kvm.h
===================================================================
--- /dev/null
+++ linux-2.6.git/include/asm-mips/kvm.h
@@ -0,0 +1,6 @@
+#ifndef __LINUX_KVM_MIPS_H
+#define __LINUX_KVM_MIPS_H
+
+/* mips does not support KVM */
+
+#endif
Index: linux-2.6.git/include/asm-mn10300/kvm.h
===================================================================
--- /dev/null
+++ linux-2.6.git/include/asm-mn10300/kvm.h
@@ -0,0 +1,6 @@
+#ifndef __LINUX_KVM_MN10300_H
+#define __LINUX_KVM_MN10300_H
+
+/* mn10300 does not support KVM */
+
+#endif
Index: linux-2.6.git/include/asm-parisc/kvm.h
===================================================================
--- /dev/null
+++ linux-2.6.git/include/asm-parisc/kvm.h
@@ -0,0 +1,6 @@
+#ifndef __LINUX_KVM_PARISC_H
+#define __LINUX_KVM_PARISC_H
+
+/* parisc does not support KVM */
+
+#endif
Index: linux-2.6.git/include/asm-powerpc/kvm.h
===================================================================
--- /dev/null
+++ linux-2.6.git/include/asm-powerpc/kvm.h
@@ -0,0 +1,6 @@
+#ifndef __LINUX_KVM_POWERPC_H
+#define __LINUX_KVM_POWERPC_H
+
+/* powerpc does not support KVM */
+
+#endif
Index: linux-2.6.git/include/asm-s390/kvm.h
===================================================================
--- /dev/null
+++ linux-2.6.git/include/asm-s390/kvm.h
@@ -0,0 +1,6 @@
+#ifndef __LINUX_KVM_S390_H
+#define __LINUX_KVM_S390_H
+
+/* s390 does not support KVM */
+
+#endif
Index: linux-2.6.git/include/asm-sh/kvm.h
===================================================================
--- /dev/null
+++ linux-2.6.git/include/asm-sh/kvm.h
@@ -0,0 +1,6 @@
+#ifndef __LINUX_KVM_SH_H
+#define __LINUX_KVM_SH_H
+
+/* sh does not support KVM */
+
+#endif
Index: linux-2.6.git/include/asm-sparc/kvm.h
===================================================================
--- /dev/null
+++ linux-2.6.git/include/asm-sparc/kvm.h
@@ -0,0 +1,6 @@
+#ifndef __LINUX_KVM_SPARC_H
+#define __LINUX_KVM_SPARC_H
+
+/* sparc does not support KVM */
+
+#endif
Index: linux-2.6.git/include/asm-sparc64/kvm.h
===================================================================
--- /dev/null
+++ linux-2.6.git/include/asm-sparc64/kvm.h
@@ -0,0 +1,6 @@
+#ifndef __LINUX_KVM_SPARC64_H
+#define __LINUX_KVM_SPARC64_H
+
+/* sparc64 does not support KVM */
+
+#endif
Index: linux-2.6.git/include/asm-um/kvm.h
===================================================================
--- /dev/null
+++ linux-2.6.git/include/asm-um/kvm.h
@@ -0,0 +1,6 @@
+#ifndef __LINUX_KVM_UM_H
+#define __LINUX_KVM_UM_H
+
+/* um does not support KVM */
+
+#endif
Index: linux-2.6.git/include/asm-v850/kvm.h
===================================================================
--- /dev/null
+++ linux-2.6.git/include/asm-v850/kvm.h
@@ -0,0 +1,6 @@
+#ifndef __LINUX_KVM_V850_H
+#define __LINUX_KVM_V850_H
+
+/* v850 does not support KVM */
+
+#endif
Index: linux-2.6.git/include/asm-xtensa/kvm.h
===================================================================
--- /dev/null
+++ linux-2.6.git/include/asm-xtensa/kvm.h
@@ -0,0 +1,6 @@
+#ifndef __LINUX_KVM_XTENSA_H
+#define __LINUX_KVM_XTENSA_H
+
+/* xtensa does not support KVM */
+
+#endif
Index: linux-2.6.git/include/linux/Kbuild
===================================================================
--- linux-2.6.git.orig/include/linux/Kbuild
+++ linux-2.6.git/include/linux/Kbuild
@@ -257,7 +257,7 @@ unifdef-y += kd.h
 unifdef-y += kernelcapi.h
 unifdef-y += kernel.h
 unifdef-y += keyboard.h
-unifdef-$(CONFIG_HAVE_KVM) += kvm.h
+unifdef-y += kvm.h
 unifdef-y += llc.h
 unifdef-y += loop.h
 unifdef-y += lp.h

  reply	other threads:[~2008-03-11  7:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-07 12:26 headersinstall of kvm.h does not work Christian Borntraeger
2008-03-07 12:57 ` Avi Kivity
2008-03-07 13:57   ` Christian Borntraeger
2008-03-07 16:08     ` Avi Kivity
2008-03-07 23:43 ` David Woodhouse
2008-03-10  8:13   ` [PATCH] kvm: provide kvm.h for all architecture: fixes headers_install Christian Borntraeger
2008-03-10 11:23     ` Arnd Bergmann
2008-03-10 13:11   ` Christian Borntraeger
2008-03-11  6:20     ` Andrew Morton
2008-03-11  6:42       ` David Woodhouse
2008-03-11  7:10         ` Christian Borntraeger [this message]
2008-03-11  9:33           ` Andreas Schwab
2008-03-11 10:02             ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803110810.49759.borntraeger@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=avi@qumranet.com \
    --cc=dhowells@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mm-commits@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --subject='Re: [PATCH] kvm: provide kvm.h for all architecture: fixes headers_install' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).