LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] x86: Remove redundant display of free swap space in show_mem()
@ 2008-03-10 16:40 Johannes Weiner
  2008-03-10 17:28 ` Hugh Dickins
  2008-03-11  9:14 ` Ingo Molnar
  0 siblings, 2 replies; 5+ messages in thread
From: Johannes Weiner @ 2008-03-10 16:40 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: Linux Kernel Mailing List

From: Johannes Weiner <hannes@saeurebad.de>

show_free_areas() already displays free swap space, no need to do it a
second time in show_mem() which calls the former anyway.

Signed-off-by: Johannes Weiner <hannes@saeurebad.de>
---
 arch/x86/mm/init_64.c    |    3 ---
 arch/x86/mm/pgtable_32.c |    1 -
 2 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
index 8230d1e..94baf63 100644
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -89,9 +89,6 @@ void show_mem(void)
 
 	printk(KERN_INFO "Mem-info:\n");
 	show_free_areas();
-	printk(KERN_INFO "Free swap:       %6ldkB\n",
-		nr_swap_pages << (PAGE_SHIFT-10));
-
 	for_each_online_pgdat(pgdat) {
 		for (i = 0; i < pgdat->node_spanned_pages; ++i) {
 			/*
diff --git a/arch/x86/mm/pgtable_32.c b/arch/x86/mm/pgtable_32.c
index 6530201..bacae27 100644
--- a/arch/x86/mm/pgtable_32.c
+++ b/arch/x86/mm/pgtable_32.c
@@ -32,7 +32,6 @@ void show_mem(void)
 
 	printk(KERN_INFO "Mem-info:\n");
 	show_free_areas();
-	printk(KERN_INFO "Free swap:       %6ldkB\n", nr_swap_pages<<(PAGE_SHIFT-10));
 	for_each_online_pgdat(pgdat) {
 		pgdat_resize_lock(pgdat, &flags);
 		for (i = 0; i < pgdat->node_spanned_pages; ++i) {
-- 
1.5.2.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] x86: Remove redundant display of free swap space in show_mem()
  2008-03-10 16:40 [PATCH] x86: Remove redundant display of free swap space in show_mem() Johannes Weiner
@ 2008-03-10 17:28 ` Hugh Dickins
  2008-03-10 18:47   ` Johannes Weiner
  2008-03-11  9:14 ` Ingo Molnar
  1 sibling, 1 reply; 5+ messages in thread
From: Hugh Dickins @ 2008-03-10 17:28 UTC (permalink / raw)
  To: Johannes Weiner; +Cc: Ingo Molnar, Linux Kernel Mailing List

On Mon, 10 Mar 2008, Johannes Weiner wrote:
> From: Johannes Weiner <hannes@saeurebad.de>
> 
> show_free_areas() already displays free swap space, no need to do it a
> second time in show_mem() which calls the former anyway.
> 
> Signed-off-by: Johannes Weiner <hannes@saeurebad.de>

I heartily approve of this; and yes, it's the per-arch one which should
go (since its "alignment" looks nasty).  But there's a lot more arches
than just x86 which should be fixed (and so rather more work, preparing
those patches for the various maintainers) - is that something you'd
have time to do?  (Don't worry, "No" is a perfectly fair answer, and
it's no way essential that all change at once.)

Thanks,
Hugh

> ---
>  arch/x86/mm/init_64.c    |    3 ---
>  arch/x86/mm/pgtable_32.c |    1 -
>  2 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
> index 8230d1e..94baf63 100644
> --- a/arch/x86/mm/init_64.c
> +++ b/arch/x86/mm/init_64.c
> @@ -89,9 +89,6 @@ void show_mem(void)
>  
>  	printk(KERN_INFO "Mem-info:\n");
>  	show_free_areas();
> -	printk(KERN_INFO "Free swap:       %6ldkB\n",
> -		nr_swap_pages << (PAGE_SHIFT-10));
> -
>  	for_each_online_pgdat(pgdat) {
>  		for (i = 0; i < pgdat->node_spanned_pages; ++i) {
>  			/*
> diff --git a/arch/x86/mm/pgtable_32.c b/arch/x86/mm/pgtable_32.c
> index 6530201..bacae27 100644
> --- a/arch/x86/mm/pgtable_32.c
> +++ b/arch/x86/mm/pgtable_32.c
> @@ -32,7 +32,6 @@ void show_mem(void)
>  
>  	printk(KERN_INFO "Mem-info:\n");
>  	show_free_areas();
> -	printk(KERN_INFO "Free swap:       %6ldkB\n", nr_swap_pages<<(PAGE_SHIFT-10));
>  	for_each_online_pgdat(pgdat) {
>  		pgdat_resize_lock(pgdat, &flags);
>  		for (i = 0; i < pgdat->node_spanned_pages; ++i) {

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] x86: Remove redundant display of free swap space in show_mem()
  2008-03-10 17:28 ` Hugh Dickins
@ 2008-03-10 18:47   ` Johannes Weiner
  0 siblings, 0 replies; 5+ messages in thread
From: Johannes Weiner @ 2008-03-10 18:47 UTC (permalink / raw)
  To: Hugh Dickins; +Cc: Ingo Molnar, Linux Kernel Mailing List

Hi,

Hugh Dickins <hugh@veritas.com> writes:

> On Mon, 10 Mar 2008, Johannes Weiner wrote:
>> From: Johannes Weiner <hannes@saeurebad.de>
>> 
>> show_free_areas() already displays free swap space, no need to do it a
>> second time in show_mem() which calls the former anyway.
>> 
>> Signed-off-by: Johannes Weiner <hannes@saeurebad.de>
>
> I heartily approve of this; and yes, it's the per-arch one which should
> go (since its "alignment" looks nasty).  But there's a lot more arches
> than just x86 which should be fixed (and so rather more work, preparing
> those patches for the various maintainers) - is that something you'd
> have time to do?  (Don't worry, "No" is a perfectly fair answer, and
> it's no way essential that all change at once.)

Yes, I will whip something up.  Thanks for the feedback.

	Hannes

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] x86: Remove redundant display of free swap space in show_mem()
  2008-03-10 16:40 [PATCH] x86: Remove redundant display of free swap space in show_mem() Johannes Weiner
  2008-03-10 17:28 ` Hugh Dickins
@ 2008-03-11  9:14 ` Ingo Molnar
  1 sibling, 0 replies; 5+ messages in thread
From: Ingo Molnar @ 2008-03-11  9:14 UTC (permalink / raw)
  To: Johannes Weiner; +Cc: Linux Kernel Mailing List


* Johannes Weiner <hannes@saeurebad.de> wrote:

> From: Johannes Weiner <hannes@saeurebad.de>
> 
> show_free_areas() already displays free swap space, no need to do it a 
> second time in show_mem() which calls the former anyway.

thanks, applied.

	Ingo

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] x86: Remove redundant display of free swap space in show_mem()
  2008-03-10 20:10 [PATCH] arm: " Johannes Weiner
@ 2008-03-10 20:10 ` Johannes Weiner
  0 siblings, 0 replies; 5+ messages in thread
From: Johannes Weiner @ 2008-03-10 20:10 UTC (permalink / raw)
  To: Linux Kernel Mailing List
  Cc: Jesper Juhl, Johannes Weiner, Thomas Gleixner, Ingo Molnar

Signed-off-by: Johannes Weiner <hannes@saeurebad.de>
---
 arch/x86/mm/init_64.c    |    3 ---
 arch/x86/mm/pgtable_32.c |    1 -
 2 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
index a02a14f..37b688d 100644
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -69,9 +69,6 @@ void show_mem(void)
 
 	printk(KERN_INFO "Mem-info:\n");
 	show_free_areas();
-	printk(KERN_INFO "Free swap:       %6ldkB\n",
-		nr_swap_pages << (PAGE_SHIFT-10));
-
 	for_each_online_pgdat(pgdat) {
 		for (i = 0; i < pgdat->node_spanned_pages; ++i) {
 			/*
diff --git a/arch/x86/mm/pgtable_32.c b/arch/x86/mm/pgtable_32.c
index 73aba71..21b7543 100644
--- a/arch/x86/mm/pgtable_32.c
+++ b/arch/x86/mm/pgtable_32.c
@@ -36,7 +36,6 @@ void show_mem(void)
 
 	printk(KERN_INFO "Mem-info:\n");
 	show_free_areas();
-	printk(KERN_INFO "Free swap:       %6ldkB\n", nr_swap_pages<<(PAGE_SHIFT-10));
 	for_each_online_pgdat(pgdat) {
 		pgdat_resize_lock(pgdat, &flags);
 		for (i = 0; i < pgdat->node_spanned_pages; ++i) {
-- 
1.5.2.2

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-03-11  9:15 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-10 16:40 [PATCH] x86: Remove redundant display of free swap space in show_mem() Johannes Weiner
2008-03-10 17:28 ` Hugh Dickins
2008-03-10 18:47   ` Johannes Weiner
2008-03-11  9:14 ` Ingo Molnar
2008-03-10 20:10 [PATCH] arm: " Johannes Weiner
2008-03-10 20:10 ` [PATCH] x86: " Johannes Weiner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).