LKML Archive on
help / color / mirror / Atom feed
From: Mathieu Desnoyers <>
To: Ingo Molnar <>
	Thomas Gleixner <>,
	Arjan van de Ven <>
Subject: Re: [PATCH] x86 Fix test_poke for vmalloced pages
Date: Tue, 11 Mar 2008 05:25:24 -0400	[thread overview]
Message-ID: <20080311092524.GA30220@Krystal> (raw)
In-Reply-To: <>

* Ingo Molnar ( wrote:
> * Mathieu Desnoyers <> wrote:
> > The shadow vmap for DEBUG_RODATA kernel text modification uses 
> > virt_to_page to get the pages from the pointer address.
> > 
> > However, I think vmalloc_to_page would be required in case the page is 
> > used for modules.
> > 
> > Since only the core kernel text is marked read-only, use 
> > kernel_text_address() to make sure we only shadow map the core kernel 
> > text, not modules.
> actually, i think we should mark module text readonly too.

I agree, then we would have to use vmalloc_to_page. I guess it has not
been done before because there wasn't any mechanism such as text_poke


> 	Ingo

Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68

  reply	other threads:[~2008-03-11  9:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-10 18:36 Mathieu Desnoyers
2008-03-11  9:09 ` Ingo Molnar
2008-03-11  9:25   ` Mathieu Desnoyers [this message]
2008-03-12 15:54   ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080311092524.GA30220@Krystal \ \ \ \ \ \
    --subject='Re: [PATCH] x86 Fix test_poke for vmalloced pages' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).