LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>,
	hpa@zytor.com, tglx@linutronix.de, andi@firstfloor.org,
	hch@infradead.org, linux-kernel@vger.kernel.org,
	Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [patch 1/2] x86, fpu: split FPU state from task struct - v5
Date: Tue, 11 Mar 2008 11:11:26 +0100	[thread overview]
Message-ID: <20080311101126.GY25110@elte.hu> (raw)
In-Reply-To: <b6fcc0a0803110309m1108382dm7b4aa714576ba813@mail.gmail.com>


* Alexey Dobriyan <adobriyan@gmail.com> wrote:

> On 3/11/08, Ingo Molnar <mingo@elte.hu> wrote:
> >
> > * Alexey Dobriyan <adobriyan@gmail.com> wrote:
> >
> > > > -	extern void __bad_fxsave_alignment(void);
> > > > -
> > > > -	if (offsetof(struct task_struct, thread.i387.fxsave) & 15)
> > > > -	__bad_fxsave_alignment();
> > >
> > > I think removal of such checks needs giving necessary alignment to
> > > cache. Previously it worked because of __aligned((16)) and
> > > L1_CACHE_SHIFT combo.
> >
> > it's still checked, just elsewhere:
> >
> > > + WARN_ON((unsigned long)dst->thread.xstate & 15);
> >
> > i'd not expect us to ever align worse than 16 bytes in the future
> 
> But sysfs tells me alignment of "xstate" is 8 now. Object size is 512 
> which is masking it.

ok - you are right, that needs to be solved then. (object size could 
change anytime someone adds a few fields for debugging or whatever)

	Ingo

  reply	other threads:[~2008-03-11 10:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-10 22:28 Suresh Siddha
2008-03-10 22:28 ` [patch 2/2] x86, fpu: lazy allocation of FPU area " Suresh Siddha
2008-03-11  9:08   ` Ingo Molnar
2008-03-11 20:57     ` Suresh Siddha
2008-03-10 22:56 ` [patch 1/2] x86, fpu: split FPU state from task struct " Andi Kleen
2008-03-11  5:07 ` Alexey Dobriyan
2008-03-11  8:35   ` Ingo Molnar
2008-03-11 10:09     ` Alexey Dobriyan
2008-03-11 10:11       ` Ingo Molnar [this message]
2008-03-11 20:22         ` Suresh Siddha
2008-03-11 20:19   ` Suresh Siddha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080311101126.GY25110@elte.hu \
    --to=mingo@elte.hu \
    --cc=adobriyan@gmail.com \
    --cc=andi@firstfloor.org \
    --cc=arjan@linux.intel.com \
    --cc=hch@infradead.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    --subject='Re: [patch 1/2] x86, fpu: split FPU state from task struct - v5' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).