LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@tv-sign.ru>
To: Roland McGrath <roland@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] signals: document CLD_CONTINUED notification mechanics
Date: Tue, 11 Mar 2008 21:36:06 +0300	[thread overview]
Message-ID: <20080311183606.GE586@tv-sign.ru> (raw)
In-Reply-To: <20080311021741.A863826F991@magilla.localdomain>

(surprisingly, this is rather important issue for me ;)

On 03/10, Roland McGrath wrote:
>
> >  		if (why) {
> > +			/* The first thread which returns from finish_stop()
> 
> Canonical style is:
> 
> 			/*
> 			 * The first thread that returns from finish_stop()

Yes, I know. But the latter needs an extra line! Don't get me wrong, I am
not worrying about the result of `wc ...`, and I often add the blank lines
to improve the readability. But since the comment block itself adds the
"space", why should we lessen the number of the code lines visible to the
reader?

Oleg.


  reply	other threads:[~2008-03-11 18:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-09 21:53 Oleg Nesterov
2008-03-11  2:17 ` Roland McGrath
2008-03-11 18:36   ` Oleg Nesterov [this message]
2008-03-11 20:28     ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080311183606.GE586@tv-sign.ru \
    --to=oleg@tv-sign.ru \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    --subject='Re: [PATCH] signals: document CLD_CONTINUED notification mechanics' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).