LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Wim Van Sebroeck <wim@iguana.be>
To: Oliver Schuster <olivers137@aol.com>,
	Andrew Paprocki <andrew@ishiboo.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [WATCHDOG] v2.5.25-rc patches
Date: Tue, 11 Mar 2008 22:02:32 +0100	[thread overview]
Message-ID: <20080311210232.GE7505@infomag.infomag.iguana.be> (raw)
In-Reply-To: <47D6CC23.5020202@aol.com>

Hi Oliver,

> this patch can cause serious problems in the case, that someone use it 
> with an it8712 rev. 8 and above.
...
> Your patch changes it8712f_wdt.c in function t8712f_wdt_update_margin():
> 
> >-	superio_outb((margin > 255) ? (margin / 60) : margin, WDT_TIMEOUT);
> >+	if (revision >= 0x08)
> >+		superio_outw(units, WDT_TIMEOUT);
> >+	else
> >+		superio_outb(units, WDT_TIMEOUT);
> 
> but here you can't use superio_outw, because the bytes are swapped 
> --historical reason.
> 
> I suggest to substitute
> 	superio_outw(units, WDT_TIMEOUT);
> with
> 	superio_outb(units >> 8, WDT_TIMEOUT + 1);
> 	superio_outb(units, WDT_TIMEOUT);
> 

Can you keep "Andrew Paprocki" <andrew@ishiboo.com> in the loop?
Can you also create a patch and test it together with Andrew?
We need to make sure that we fix this before 2.6.25 is there.

Thanks,
Wim.


  reply	other threads:[~2008-03-11 21:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-10 20:14 Wim Van Sebroeck
2008-03-11 18:14 ` Oliver Schuster
2008-03-11 21:02   ` Wim Van Sebroeck [this message]
2008-04-01 15:06     ` [PATCH][WATCHDOG] v2.6.25-rc7: it8712f_wdt.c contains an error - was " Oliver Schuster
2008-04-01 15:27       ` Andrew Paprocki
  -- strict thread matches above, loose matches on Subject: below --
2008-03-11 13:21 Oliver Schuster
2008-02-19 12:24 Wim Van Sebroeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080311210232.GE7505@infomag.infomag.iguana.be \
    --to=wim@iguana.be \
    --cc=akpm@linux-foundation.org \
    --cc=andrew@ishiboo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olivers137@aol.com \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [WATCHDOG] v2.5.25-rc patches' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).