LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: "Pekka Enberg" <penberg@cs.helsinki.fi>
Cc: "Mathieu Desnoyers" <mathieu.desnoyers@polymtl.ca>,
	"Christoph Lameter" <clameter@sgi.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] Implement slub fastpath with sequence number
Date: Wed, 12 Mar 2008 10:13:20 +1100	[thread overview]
Message-ID: <200803121013.20810.nickpiggin@yahoo.com.au> (raw)
In-Reply-To: <84144f020803110745jcc73368l84e2268b68133520@mail.gmail.com>

On Wednesday 12 March 2008 01:45, Pekka Enberg wrote:
> Hi Nick,
>
> On Tue, Mar 11, 2008 at 11:41 AM, Nick Piggin <nickpiggin@yahoo.com.au> 
wrote:
> >  Wow. I applaud the effort to micro optimise things ;)
> >
> >  But I hope this doesn't get merged until macro-regressions in SLUB
> >  are verified to be fixed. It's pretty clear that SLUB's problem is
> >  not fastpath performance, so I think this would be premature
> >  optimisation.
>
> What regressions are you referring to? The SLAB_HWCACHE_ALIGN
> regression patch you sent is being merged. What else?

The oracle/tpcc one I don't know if it has been fixed?


> And FWIW, I don't like the patch because it makes the code very hairy.
> But I don't see why we shouldn't merge SLUB fast-path optimizations if
> they're clean and you have the numbers to show it's a gain even if
> there are other remaining regressions.

I'm talking about this patch specifically though. It makes it much
harder to work with.


  reply	other threads:[~2008-03-11 23:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-11  9:31 Mathieu Desnoyers
2008-03-11  9:41 ` Nick Piggin
2008-03-11 14:45   ` Pekka Enberg
2008-03-11 23:13     ` Nick Piggin [this message]
2008-03-12  4:14       ` Christoph Lameter
2008-03-11 14:34 ` Peter Zijlstra
2008-03-12  4:15   ` Christoph Lameter
2008-03-12 22:17   ` Mathieu Desnoyers
2008-03-13  1:20     ` Mathieu Desnoyers
2008-03-13  1:35       ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803121013.20810.nickpiggin@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=penberg@cs.helsinki.fi \
    --subject='Re: [RFC PATCH] Implement slub fastpath with sequence number' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).