LKML Archive on
help / color / mirror / Atom feed
From: Oleg Nesterov <>
To: Roland McGrath <>
Cc: Andrew Morton <>,
	Ingo Molnar <>, Pavel Emelyanov <>,
Subject: Re: [PATCH 8/6] signals: send_signal: factor out SIGNAL_GROUP_EXIT checks
Date: Thu, 13 Mar 2008 01:08:24 +0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20080312215406.A786526F992@magilla.localdomain>

On 03/12, Roland McGrath wrote:
> > Of course, since I personally don't agree, I'd like to discuss it more
> > if possible.
> The point is that, whenever possible, a semantics change should be
> isolated into a patch separate from any related cleanups.  More
> important than that, no semantics change should go unmentioned so
> it's only documented as a result of someone's careful review of
> the change.

Yes. You are very right.

And. I must admit. I didn't even realize that the added semantics change
worth at least a special note in changelog because it is easily visible.
This was really wrong in any case. Thanks for pointing out this.


      reply	other threads:[~2008-03-12 22:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-09 18:59 Oleg Nesterov
2008-03-11  2:16 ` Roland McGrath
2008-03-11 17:51   ` Oleg Nesterov
2008-03-11 20:32     ` Roland McGrath
2008-03-12  5:49       ` Oleg Nesterov
2008-03-12 21:54         ` Roland McGrath
2008-03-12 22:08           ` Oleg Nesterov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 8/6] signals: send_signal: factor out SIGNAL_GROUP_EXIT checks' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).