LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: David Brownell <david-b@pacbell.net>
Cc: Liam Girdwood <lg@opensource.wolfsonmicro.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-arm-kernel@lists.arm.linux.org.uk,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Dmitry Baryshkov <dbaryshkov@gmail.com>
Subject: Re: [UPDATED v3][PATCH 1/7] regulator: consumer interface
Date: Thu, 13 Mar 2008 12:00:51 +0000	[thread overview]
Message-ID: <20080313120051.GA32729@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <200803122208.49040.david-b@pacbell.net>

On Wed, Mar 12, 2008 at 09:08:48PM -0800, David Brownell wrote:
> On Wednesday 12 March 2008, Mark Brown wrote:

> > Hrm.  I suspect that the documentation which Liam is currently writing
> > (together with some actual in-tree users) will help here.

> Yes, code is only one part of a balanced architecture.
> It's pretty weak at conveying any "big picture" issues,
> especially with only one underlying implementation.  If
> I can't get that picture without reviewing 100+ KBytes
> of code, then something critical is missing...

OK, that's good - from what you were saying it sounded like you had some
more fundamental objection.  Users are probably at least as important as
text documentation here since it's them that people tend to look at when
they need to look at code.  As with a lot of things the core isn't the
best thing to look at since it has to care about the things that it is
abstracting away from users.

> I've been pushing for clear explanations in part because,
> well, nobody else has.  I've come across clear needs for
> basic power switching, to manage sections of both SOCs and
> boards; and less clear needs for voltage adjustment.  I've
> been hoping some of the other folk who have looked at these
> issues would chime in.

The ability to adjust voltage is required for devices like MMC and CPU
frequency control so it needs to be implemented to at least some degree
and if we do it for everything it reduces the number of special cases to
handle.  Systems that don't need or want it can disable it by setting an
exact constraint in the platform code at which point it decays into a
safety feature.

  reply	other threads:[~2008-03-13 12:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-06 18:10 Liam Girdwood
2008-03-08  3:43 ` David Brownell
2008-03-09 11:10   ` Liam Girdwood
2008-03-11  0:39     ` David Brownell
2008-03-11 10:20       ` Liam Girdwood
2008-03-11 21:36         ` David Brownell
2008-03-11 22:25           ` David Brownell
2008-03-12  0:00             ` Mark Brown
2008-03-12  7:31               ` David Brownell
2008-03-12 13:02                 ` Mark Brown
2008-03-12 21:52                   ` David Brownell
2008-03-12 23:26                     ` ian
2008-03-13  4:39                       ` David Brownell
2008-03-12 23:57                     ` Mark Brown
2008-03-13  5:08                       ` David Brownell
2008-03-13 12:00                         ` Mark Brown [this message]
2008-03-11  2:00     ` David Brownell
2008-03-11 15:19       ` Liam Girdwood
2008-03-12  6:29         ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080313120051.GA32729@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=akpm@linux-foundation.org \
    --cc=david-b@pacbell.net \
    --cc=dbaryshkov@gmail.com \
    --cc=lg@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [UPDATED v3][PATCH 1/7] regulator: consumer interface' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).