LKML Archive on
help / color / mirror / Atom feed
From: Roland McGrath <>
To: Ingo Molnar <>, Thomas Gleixner <>
Cc: Andrew Morton <>,
Subject: [PATCH 1/2] x86_64 ia32 ptrace vs -ENOSYS
Date: Sun, 16 Mar 2008 21:57:41 -0700 (PDT)	[thread overview]
Message-ID: <20080317045741.2F6A526F995@magilla.localdomain> (raw)

When we're stopped at syscall entry tracing, ptrace can change the %eax
value from -ENOSYS to something else.  If no system call is actually made
because the syscall number (now in orig_eax) is bad, then the %eax value
set by ptrace should be returned to the user.  But, instead it gets reset
to -ENOSYS again.  This is a regression from the native 32-bit kernel.

This change fixes it by leaving the return value alone after entry tracing.

Signed-off-by: Roland McGrath <>
 arch/x86/ia32/ia32entry.S |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/ia32/ia32entry.S b/arch/x86/ia32/ia32entry.S
index b42d009..eafb0b9 100644
--- a/arch/x86/ia32/ia32entry.S
+++ b/arch/x86/ia32/ia32entry.S
@@ -325,7 +325,7 @@ ENTRY(ia32_syscall)
 	jnz ia32_tracesys
 	cmpl $(IA32_NR_syscalls-1),%eax
-	ja  ia32_badsys
+	ja  int_ret_from_sys_call	/* ia32_tracesys has set RAX(%rsp) */
 	call *ia32_sys_call_table(,%rax,8) # xxx: rip relative
@@ -335,7 +335,7 @@ ia32_sysret:
-	movq $-ENOSYS,RAX(%rsp)	/* really needed? */
+	movq $-ENOSYS,RAX(%rsp)	/* ptrace can change this for a bad syscall */
 	movq %rsp,%rdi        /* &pt_regs -> arg1 */
 	call syscall_trace_enter
 	LOAD_ARGS32 ARGOFFSET  /* reload args from stack in case ptrace changed it */

             reply	other threads:[~2008-03-17  4:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-17  4:57 Roland McGrath [this message]
2008-03-17  4:59 ` [PATCH 2/2] x86_64 " Roland McGrath
2008-03-19  1:23 ` [PATCH] x86_64 ia32 ptrace vs -ENOSYS sysenter/syscall Roland McGrath
2008-03-19 22:17 ` [PATCH 1/2] x86_64 ia32 ptrace vs -ENOSYS Andrew Morton
2008-03-19 23:36   ` Roland McGrath
2008-03-21 10:33     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080317045741.2F6A526F995@magilla.localdomain \ \ \ \ \ \
    --subject='Re: [PATCH 1/2] x86_64 ia32 ptrace vs -ENOSYS' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).