LKML Archive on
help / color / mirror / Atom feed
From: Rusty Russell <>
To: "Jan Beulich" <>
Cc:, Andrew Morton <>
Subject: Re: [PATCH] fix verify_export_symbols()
Date: Tue, 18 Mar 2008 11:29:32 +1100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tuesday 18 March 2008 09:36:04 Rusty Russell wrote:
> On Thursday 13 March 2008 20:04:17 you wrote:
> > When the newer export flavors were added, it was apparently forgotten
> > to add respective code here.
> > In order to not double the (source) size of the function, add some
> > abstraction to reduce code duplication.
> Hi Jan,
>    Actually, the others did exist, they just weren't checked.

No, my bad, you're right (GPL-only existed, but they were covered already).  
The problem with this is that we'll get a bogus unused warning in the case of 
doing a __find_symbol on an unused symbol.

It's time for a general cleanup of the __find_symbol logic.  I'll post when 
it's done.


  reply	other threads:[~2008-03-18  0:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-13  9:04 Jan Beulich
2008-03-17 22:36 ` Rusty Russell
2008-03-18  0:29   ` Rusty Russell [this message]
2008-03-20  5:25     ` [PATCH 1/2] module: neaten __find_symbol, rename to find_symbol Rusty Russell
2008-03-20  5:27       ` [PATCH 2/2] module: Enhance verify_export_symbols Rusty Russell
  -- strict thread matches above, loose matches on Subject: below --
2008-01-10 16:37 [PATCH] fix verify_export_symbols() Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: [PATCH] fix verify_export_symbols()' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).