From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755372AbYCRAfl (ORCPT ); Mon, 17 Mar 2008 20:35:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752202AbYCRAfe (ORCPT ); Mon, 17 Mar 2008 20:35:34 -0400 Received: from ozlabs.org ([203.10.76.45]:60957 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752121AbYCRAfe (ORCPT ); Mon, 17 Mar 2008 20:35:34 -0400 From: Rusty Russell To: "Jan Beulich" Subject: Re: [PATCH] fix verify_export_symbols() Date: Tue, 18 Mar 2008 11:29:32 +1100 User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405) Cc: linux-kernel@vger.kernel.org, Andrew Morton References: <47D8FC21.76E4.0078.0@novell.com> <200803180936.04586.rusty@rustcorp.com.au> In-Reply-To: <200803180936.04586.rusty@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200803181129.32399.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 18 March 2008 09:36:04 Rusty Russell wrote: > On Thursday 13 March 2008 20:04:17 you wrote: > > When the newer export flavors were added, it was apparently forgotten > > to add respective code here. > > In order to not double the (source) size of the function, add some > > abstraction to reduce code duplication. > > Hi Jan, > > Actually, the others did exist, they just weren't checked. No, my bad, you're right (GPL-only existed, but they were covered already). The problem with this is that we'll get a bogus unused warning in the case of doing a __find_symbol on an unused symbol. It's time for a general cleanup of the __find_symbol logic. I'll post when it's done. Thanks! Rusty.