LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ptrace: ptrace_attach: use send_sig_info() instead force_sig_specific()
@ 2008-03-18 16:33 Oleg Nesterov
  2008-03-18 22:09 ` Roland McGrath
  0 siblings, 1 reply; 2+ messages in thread
From: Oleg Nesterov @ 2008-03-18 16:33 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Roland McGrath, linux-kernel

(depends on signals-send_sig_info-dont-take-tasklist_lock.patch)

Nobody can block/ignore SIGSTOP, no need to use force_sig_specific() in
ptrace_attach. Use the "regular" send_sig_info().

With this patch stracing of /sbin/init doesn't clear its SIGNAL_UNKILLABLE,
but not that this makes ptracing of init safe.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>

--- 25/kernel/ptrace.c~5_PTRACE_STOP_NO_FORCE	2008-03-16 18:33:02.000000000 +0300
+++ 25/kernel/ptrace.c	2008-03-18 19:15:54.000000000 +0300
@@ -217,8 +217,7 @@ repeat:
 
 	__ptrace_link(task, current);
 
-	force_sig_specific(SIGSTOP, task);
-
+	send_sig_info(SIGSTOP, SEND_SIG_FORCED, task);
 bad:
 	write_unlock_irqrestore(&tasklist_lock, flags);
 	task_unlock(task);


^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: [PATCH] ptrace: ptrace_attach: use send_sig_info() instead force_sig_specific()
  2008-03-18 16:33 [PATCH] ptrace: ptrace_attach: use send_sig_info() instead force_sig_specific() Oleg Nesterov
@ 2008-03-18 22:09 ` Roland McGrath
  0 siblings, 0 replies; 2+ messages in thread
From: Roland McGrath @ 2008-03-18 22:09 UTC (permalink / raw)
  To: Oleg Nesterov; +Cc: Andrew Morton, linux-kernel

Looks right to me.

Thanks,
Roland

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-19 23:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-18 16:33 [PATCH] ptrace: ptrace_attach: use send_sig_info() instead force_sig_specific() Oleg Nesterov
2008-03-18 22:09 ` Roland McGrath

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).