LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Laurent Vivier <Laurent.Vivier@bull.net>
Cc: randy.dunlap@oracle.com, jens.axboe@oracle.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH][v4]  Modify loop device to be able to manage partitions of the disk image
Date: Wed, 19 Mar 2008 14:28:21 -0700	[thread overview]
Message-ID: <20080319142821.73d280f3.akpm@linux-foundation.org> (raw)
In-Reply-To: <1205958281.4758.7.camel@frecb07144>

On Wed, 19 Mar 2008 21:24:41 +0100
Laurent Vivier <Laurent.Vivier@bull.net> wrote:

> Le mercredi 19 mars 2008 __ 13:11 -0700, Randy Dunlap a __crit :
> > On Wed, 19 Mar 2008 13:36:07 +0100 Laurent Vivier wrote:
> > 
> > > This patch allows to use loop device with partitionned disk image.
> > > 
> > > Original behavior of loop is not modified.
> > > 
> > > A new parameter is introduced to define how many partition we want to be
> > > able to manage per loop device. This parameter is "max_part".
> > 
> > What happened to the update to Documentation/kernel-parameters.txt
> > that was in v3?
> 
> Well, perhaps I didn't understand the comment of Andrew:
> 
> "This shouldn't be needed."
> 
> I though it means I should remove it. So, Andrew ???

No, given that all module_param() options are available via the boot
command line when the module is linked into vmlinux, we don't document them
separately.

There should be a way of auto-generating all the documentation for all the
module parameters from their MODULE_PARM_DESC's.  And there probably is,
but I'm not sure how this is done (?)

(does `make help', fails to spot it).

You can do `modinfo loop' but that probably doesn't work if
CONFIG_BLK_DEV_LOOP=y?



I assume you tested the "loop.max_part=N" option?


  reply	other threads:[~2008-03-19 23:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-18 12:19 [PATCH][RESEND][v3] " Laurent Vivier
2008-03-18 20:54 ` Andrew Morton
2008-03-19 12:36 ` [PATCH][v4] " Laurent Vivier
2008-03-19 20:11   ` Randy Dunlap
2008-03-19 20:24     ` Laurent Vivier
2008-03-19 21:28       ` Andrew Morton [this message]
2008-03-19 21:39         ` Laurent Vivier
2008-03-19 21:43           ` Andrew Morton
2008-03-19 23:03         ` Randy Dunlap
2008-03-20 21:36         ` Bill Davidsen
2008-03-19 20:24 ` [PATCH][RESEND][v3] " Bill Davidsen
2008-03-19 20:32   ` Laurent Vivier
2008-03-23 23:33     ` Bill Davidsen
2008-03-25 10:34       ` [PATCH] Modify Network Block Device (nbd) to be able to manage partitions Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080319142821.73d280f3.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=Laurent.Vivier@bull.net \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --subject='Re: [PATCH][v4]  Modify loop device to be able to manage partitions of the disk image' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).