LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Roland McGrath <roland@redhat.com>
Cc: mingo@elte.hu, tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86_64 ia32 ptrace vs -ENOSYS
Date: Wed, 19 Mar 2008 15:17:58 -0700	[thread overview]
Message-ID: <20080319151758.29e02848.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080317045741.2F6A526F995@magilla.localdomain>

On Sun, 16 Mar 2008 21:57:41 -0700 (PDT)
Roland McGrath <roland@redhat.com> wrote:

> When we're stopped at syscall entry tracing, ptrace can change the %eax
> value from -ENOSYS to something else.  If no system call is actually made
> because the syscall number (now in orig_eax) is bad, then the %eax value
> set by ptrace should be returned to the user.  But, instead it gets reset
> to -ENOSYS again.  This is a regression from the native 32-bit kernel.
> 
> This change fixes it by leaving the return value alone after entry tracing.

It is unclear (to me) what are the consequences of this problem?  What
are the user-visible effects of the fix?

IOW: is it a 2.6.25 thing and if so, why?

Thanks.

  parent reply	other threads:[~2008-03-19 23:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-17  4:57 Roland McGrath
2008-03-17  4:59 ` [PATCH 2/2] x86_64 " Roland McGrath
2008-03-19  1:23 ` [PATCH] x86_64 ia32 ptrace vs -ENOSYS sysenter/syscall Roland McGrath
2008-03-19 22:17 ` Andrew Morton [this message]
2008-03-19 23:36   ` [PATCH 1/2] x86_64 ia32 ptrace vs -ENOSYS Roland McGrath
2008-03-21 10:33     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080319151758.29e02848.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=roland@redhat.com \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH 1/2] x86_64 ia32 ptrace vs -ENOSYS' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).