Re: suspend slow in 2.6.25-rc6 (was Re: Suspend and hibernation patchset against -rc6)

[Pavel Machek <pavel@ucw.cz>]

On Wed 2008-03-19 22:58:59, Rafael J. Wysocki wrote:
> On Wednesday, 19 of March 2008, Pavel Machek wrote:
> > 
> > > > >> Revert ec.c to 2.6.25-rc5 state:
> > > > >>
> > > > >> * this fixes backlight after closing/reopening the lid while in X on
> > > > >> thinkpad x60
> > > > >>
> > > > >> * unfortunately it breaks fn-home/end keyboard brightness control
> > > > > It should also break volume up/down/mute keys. Essentially all the keys on Thinkpad.
> > > > > And it would also be regression to 2.6.24 level.
> > > > 
> > > > As I explained above.
> > > > 
> > > > Unfortunately, applying this means I loose screen as soon as I
> > > > close/reopen lid. 2.6.24 did not behave like that. And it makes my
> > > > machine mostly unusable -- as soon as you try to carry it away, you
> > > > loose video. BAD.
> > > 
> > > Can you text the current -git (preferably without anything on top) pretty please?
> > 
> > Did anything relevant change in the last 8 hours or so?
> 
> No, it didn't.
> 
> > My scripts tell me there's nothing to pull:
> > 
> > Done counting 441 objects.
> > Result has 304 objects.
> > Deltifying 304 objects.
> >  100% (304/304) done
> > Total 304, written 304 (delta 236), reused 121 (delta 75)
> > Fetching pack (head and objects)...
> > Fetching tags...
> > Up to date.
> > 
> > Applying changes...
> > Branch already fully merged.
> > pavel@amd:~$
> 
> Still, the current -git has the offending patch reverted and you're seeing a
> regression nevertheless.
> 
> Is that correct?

Yes.

(Or more precisely, there are two regressions:

* s2ram 5 seconds slower -- fixed by current git

* backlight goes out in X -- not fixed by current git)

								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
pomozte zachranit klanovicky les:  http://www.ujezdskystrom.info/