LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: vda.linux@googlemail.com
Cc: xemul@openvz.org, akpm@linux-foundation.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	ebiederm@xmission.com, adobriyan@openvz.org
Subject: Re: [PATCH] Make /proc/net a symlink on /proc/self/net
Date: Sun, 23 Mar 2008 06:16:50 -0700 (PDT)	[thread overview]
Message-ID: <20080323.061650.239772151.davem@davemloft.net> (raw)
In-Reply-To: <200803231400.41397.vda.linux@googlemail.com>

From: Denys Vlasenko <vda.linux@googlemail.com>
Date: Sun, 23 Mar 2008 14:00:41 +0100

> On Wednesday 05 March 2008 13:20, Pavel Emelyanov wrote:
> > Current /proc/net is done with so called "shadows", but current
> > implementation is broken and has little chances to get fixed.
> > 
> > The problem is that dentries subtree of /proc/net directory has
> > fancy revalidation rules to make processes living in different
> > net namespaces see different entries in /proc/net subtree, but
> > currently, tasks see in the /proc/net subdir the contents of any
> > other namespace, depending on who opened the file first.
> > 
> > The proposed fix is to turn /proc/net into a symlink, which points
> > to /proc/self/net, which in turn shows what previously was in
> > /proc/net - the network-related info, from the net namespace the
> > appropriate task lives in.
> > 
> > # ls -l /proc/net
> > lrwxrwxrwx  1 root root 8 Mar  5 15:17 /proc/net -> self/net
> 
> This broke tools which read /proc/net/dev. Under non-root,
> they are no longer working. This is a regression.

This is fixed with a commit that was made yesterday.

      parent reply	other threads:[~2008-03-23 13:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-05 12:20 Pavel Emelyanov
2008-03-05 19:15 ` Paul E. McKenney
2008-03-05 21:29   ` David Miller
2008-03-05 23:59   ` Eric W. Biederman
2008-03-06  0:22     ` Paul E. McKenney
2008-03-06  8:25   ` Pavel Emelyanov
2008-03-06  0:24 ` Eric W. Biederman
2008-03-06  8:40   ` Pavel Emelyanov
2008-03-23 13:00 ` Denys Vlasenko
2008-03-23 13:04   ` Denys Vlasenko
2008-03-23 13:16   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080323.061650.239772151.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=adobriyan@openvz.org \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vda.linux@googlemail.com \
    --cc=xemul@openvz.org \
    --subject='Re: [PATCH] Make /proc/net a symlink on /proc/self/net' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).