LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: fhimpe@telenet.be
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6] [TCP]: Must count fack_count also when skipping
Date: Mon, 24 Mar 2008 14:41:07 -0700 (PDT)	[thread overview]
Message-ID: <20080324.144107.235200795.davem@davemloft.net> (raw)
In-Reply-To: <pan.2008.03.24.20.36.07@telenet.be>

From: Frederik Himpe <fhimpe@telenet.be>
Date: Mon, 24 Mar 2008 20:36:08 +0000 (UTC)

> On Mon, 03 Mar 2008 15:53:12 +0200, Ilpo Järvinen
> wrote:
> 
> > [PATCH net-2.6] [TCP]: Must count fack_count also when skipping
> > 
> > It makes fackets_out to grow too slowly compared with the real write
> > queue.
> > 
> > This shouldn't cause those BUG_TRAP(packets <= tp->packets_out) to
> > trigger but how knows how such inconsistent fackets_out affects here and
> > there around TCP when everything is nowadays assuming accurate
> > fackets_out. So lets see if this silences them all.
> > 
> > Reported by Guillaume Chazarain <guichaz@gmail.com>.
> 
> Will this patch be applied to 2.6.24 stable? I think I have been hit by 
> the same problem recently:

I'll push it to the -stable folks for their next release
since people are actively hitting it.

  reply	other threads:[~2008-03-24 21:41 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-21  4:04 WARNING: at net/ipv4/tcp_input.c:2054 tcp_mark_head_lost() Giangiacomo Mariotti
2008-02-23  8:03 ` Andrew Morton
2008-02-27  9:29   ` Ilpo Järvinen
2008-02-27 18:56     ` Guillaume Chazarain
2008-02-27 19:29       ` Ilpo Järvinen
2008-02-28  8:22         ` Ilpo Järvinen
2008-02-29  1:10           ` Andrew Morton
2008-02-29  4:35             ` Bill Fink
2008-02-29 12:24               ` Ilpo Järvinen
2008-03-02 12:20           ` Guillaume Chazarain
2008-03-02 12:38             ` Ilpo Järvinen
2008-03-02 13:15               ` Guillaume Chazarain
2008-03-02 19:51                 ` Ilpo Järvinen
2008-03-03  8:32                   ` Ilpo Järvinen
2008-03-03 13:40                     ` Ilpo Järvinen
2008-03-03 13:53                       ` [PATCH net-2.6] [TCP]: Must count fack_count also when skipping Ilpo Järvinen
2008-03-03 20:11                         ` David Miller
2008-03-24 20:36                         ` Frederik Himpe
2008-03-24 21:41                           ` David Miller [this message]
2008-03-25 21:24                             ` Ilpo Järvinen
2008-03-26  3:05                               ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080324.144107.235200795.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=fhimpe@telenet.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH net-2.6] [TCP]: Must count fack_count also when skipping' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).