LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] SuperH floppy: kill 'register' keyword from floppy.h header
@ 2008-03-26 1:16 Jesper Juhl
2008-03-26 9:22 ` Paul Mundt
0 siblings, 1 reply; 2+ messages in thread
From: Jesper Juhl @ 2008-03-26 1:16 UTC (permalink / raw)
To: LKML
Cc: Paul Mundt, linux-sh, Ian Molton, Alain L Knaff, David C Niemi,
Trivial Patch Monkey, Andrew Morton
When compilers became generally better at optimizing code than humans, the
register keyword became mostly useless. For the floppy driver it certainly
is since it's so slow compared to the rest of the system that optimizing
access to a single variable or two isn't going to make any real
difference
So let's just leave it to the compiler - it'll do a better job anyway.
This patch does away with a few register keywords in the SuperH floppy
driver.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
floppy.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/asm-sh/floppy.h b/include/asm-sh/floppy.h
index 59fbfdc..afa7f8f 100644
--- a/include/asm-sh/floppy.h
+++ b/include/asm-sh/floppy.h
@@ -54,7 +54,7 @@ static int doing_pdma;
static void floppy_hardint(int irq, void *dev_id, struct pt_regs * regs)
{
- register unsigned char st;
+ unsigned char st;
#undef TRACE_FLPY_INT
@@ -74,8 +74,8 @@ static void floppy_hardint(int irq, void *dev_id, struct pt_regs * regs)
#endif
{
- register int lcount;
- register char *lptr;
+ int lcount;
+ char *lptr;
st = 1;
for(lcount=virtual_dma_count, lptr=virtual_dma_addr;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] SuperH floppy: kill 'register' keyword from floppy.h header
2008-03-26 1:16 [PATCH] SuperH floppy: kill 'register' keyword from floppy.h header Jesper Juhl
@ 2008-03-26 9:22 ` Paul Mundt
0 siblings, 0 replies; 2+ messages in thread
From: Paul Mundt @ 2008-03-26 9:22 UTC (permalink / raw)
To: Jesper Juhl
Cc: LKML, linux-sh, Ian Molton, Alain L Knaff, David C Niemi,
Trivial Patch Monkey, Andrew Morton
On Wed, Mar 26, 2008 at 02:16:32AM +0100, Jesper Juhl wrote:
>
> When compilers became generally better at optimizing code than humans, the
> register keyword became mostly useless. For the floppy driver it certainly
> is since it's so slow compared to the rest of the system that optimizing
> access to a single variable or two isn't going to make any real
> difference
> So let's just leave it to the compiler - it'll do a better job anyway.
>
> This patch does away with a few register keywords in the SuperH floppy
> driver.
>
>
> Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-26 9:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-26 1:16 [PATCH] SuperH floppy: kill 'register' keyword from floppy.h header Jesper Juhl
2008-03-26 9:22 ` Paul Mundt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).